[HOLD for payment 2024-08-14] [$500][P2P Distance] Create UpdateMoneyRequestDistanceRate in App #36987

Activity

1. neil-marcellini

   added this to [#whatsnext] Wave 06 - Collect Submitterson Feb 21, 2024
2. neil-marcellini

   moved this to MEDIUM in [#whatsnext] Wave 06 - Collect Submitterson Feb 21, 2024
3. neil-marcellini

   changed the title [-][P2P Distance] Create UpdateMoneyRequestRate[/-] [+][P2P Distance] Create UpdateMoneyRequestRate in App[/+] on Feb 21, 2024
4. neil-marcellini

   added

   ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributor

   Engineering

   DailyKSv2KSv2

   Help WantedApply this label when an issue is open to proposals by contributorsApply this label when an issue is open to proposals by contributors

   on Feb 21, 2024
5. melvin-bot

   changed the title [-][P2P Distance] Create UpdateMoneyRequestRate in App[/-] [+][$500] [P2P Distance] Create UpdateMoneyRequestRate in App[/+] on Feb 21, 2024
6. melvin-bot commented on Feb 21, 2024

   

   melvin-botBot

   on Feb 21, 2024 – with Melvin Bot

   More actions

   Job added to Upwork: https://www.upwork.com/jobs/~01fde353d38f5fdf1b
7. melvin-bot commented on Feb 21, 2024

   

   melvin-botBot

   on Feb 21, 2024 – with Melvin Bot

   More actions

   Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)
8. melvin-bot

   assigned

   mananjadhav

   on Feb 21, 2024
9. neil-marcellini

   added

   NewFeatureSomething to build that is a new item.Something to build that is a new item.

   on Feb 21, 2024
10. melvin-bot

    assigned

    stephanieelliott

    on Feb 21, 2024
11. melvin-bot commented on Feb 21, 2024

    

    melvin-botBot

    on Feb 21, 2024 – with Melvin Bot

    More actions

    Triggered auto assignment to @stephanieelliott (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.
12. melvin-bot

    added

    WeeklyKSv2KSv2

    on Feb 21, 2024
13. 93 remaining items

    Load more
14. melvin-bot

    added

    WeeklyKSv2KSv2

    Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to production

    on Aug 7, 2024
15. melvin-bot

    changed the title [-][$500][P2P Distance] Create UpdateMoneyRequestDistanceRate in App[/-] [+][HOLD for payment 2024-08-14] [$500][P2P Distance] Create UpdateMoneyRequestDistanceRate in App[/+] on Aug 7, 2024
16. melvin-bot commented on Aug 7, 2024

    

    melvin-botBot

    on Aug 7, 2024 – with Melvin Bot

    More actions

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    • feat: Edit Distance Rate flow #40021

    If no regressions arise, payment will be issued on 2024-08-14. 🎊

    For reference, here are some details about the assignees on this issue:

    • @mananjadhav requires payment through NewDot Manual Requests
    • @paultsimura requires payment automatic offer (Contributor)
    • @koko57 does not require payment (Contractor)
17. melvin-bot commented on Aug 7, 2024

    

    melvin-botBot

    on Aug 7, 2024 – with Melvin Bot

    More actions

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@mananjadhav / @paultsimura] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
18. melvin-bot

    added

    DailyKSv2KSv2

    Overdue

    and removed

    WeeklyKSv2KSv2

    on Aug 14, 2024
19. stephanieelliott commented on Aug 16, 2024

    

    stephanieelliott

    on Aug 16, 2024

    Contributor

    More actions

    Summarizing payment on this issue:

    • Contributor: @paultsimura $500 via Upwork -- PAID
    • Contributor+: @mananjadhav $500 via NewDot -- please request

    @manjesh-yadav @paultsimura as the last step on this issue, can you please propose a regression test?

    Upwork job is here: https://www.upwork.com/jobs/~01fde353d38f5fdf1b

    ❤️React with ❤️1Reacted by Pavlo Tsimura
20. melvin-bot

    removed

    Overdue

    on Aug 16, 2024
21. paultsimura commented on Aug 16, 2024

    

    paultsimura

    on Aug 16, 2024

    Contributor

    More actions

    @mananjadhav was out sick these days, but I think he'll add the tests here as he was the C+.
22. mananjadhav commented on Aug 16, 2024

    

    mananjadhav

    on Aug 16, 2024

    Collaborator

    More actions

    Thanks @stephanieelliott. This is more of a feature request so we don't have any offending PR.

    Regression Test proposal.

    1. Open the app and have a workspace with multiple distance rates.
    2. Create a Distance request to the workspace
    3. Navigate to the request details page
    4. Click the "Rate" field and change the rate
    5. Verify the rate & amount are changed correctly
    6. Verify the "modified expense" action was added
    7. Now, create a Distance request to self via "track expense"
    8. Navigate to the request details page
    9. Verify the "Rate" field is not clickable
23. stephanieelliott commented on Aug 17, 2024

    

    stephanieelliott

    on Aug 17, 2024

    Contributor

    More actions

    Thanks @mananjadhav! Regression test issue created here: https://github.com/Expensify/Expensify/issues/421162
24. stephanieelliott

    closed this as completedon Aug 17, 2024
25. JmillsExpensify commented on Aug 20, 2024

    

    JmillsExpensify

    on Aug 20, 2024

    Contributor

    More actions

    $500 approved for @mananjadhav