Skip to content

[$500] Hold Request - Submitting report with expenses that on hold returns unexpected error #37017

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Found when validating PR : #33897

Version Number: 1.4.43-6
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:

Action Performed:

Precondition: create a workspace, and invite an employee and approver

  1. Go to https://staging.new.expensify.com/

  2. Log in as an employee

  3. Navigate to a workspace chat

  4. Create a manual request

  5. Navigate to the expense detail page

  6. Click on 3 dots > Hold request

  7. Enter a reason and click on Hold request

  8. Return to the expense report and submit the report

Expected Result:

The report is submitted and the system message is displayed

Actual Result:

The error message "Unexpected error, please try again later" is shown. After refreshing the page, the system message that the report was submitted is displayed.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6386873_1708521501608.Recording__223.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ff1a69fd67e7b5ae
  • Upwork Job ID: 1760296204787605504
  • Last Price Increase: 2024-02-21
Issue OwnerCurrent Issue Owner: @allroundexperts

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 21, 2024
  2. changed the title [-]Hold Request - Submitting report with expenses that on hold returns unexpected error[/-] [+][$500] Hold Request - Submitting report with expenses that on hold returns unexpected error[/+] on Feb 21, 2024
  3. melvin-bot commented on Feb 21, 2024

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 21, 2024
  5. melvin-bot commented on Feb 21, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

  6. melvin-bot commented on Feb 21, 2024

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  7. github-actions commented on Feb 21, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. 36 remaining items

  9. mallenexpensify commented on Apr 23, 2024

    @mallenexpensify
    Contributor

    Bobby Bottles, is there a link for Partial Pay/Approve ?

  10. robertjchen commented on May 1, 2024

    @robertjchen
    Contributor

    yep! https://github.com/Expensify/Expensify/issues/378314

    Seeing that it has gone out, let's retest this and see if it's still happening 👍

  11. added
    retest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause
    on May 1, 2024
  12. mvtglobally commented on May 13, 2024

    @mvtglobally

    Issue not reproducible during KI retests. (First week)

  13. mallenexpensify commented on May 15, 2024

    @mallenexpensify
    Contributor

    Tried to repro but not seeing HOLD option in upper tight when I click the three stacked dots
    image

  14. mvtglobally commented on May 22, 2024

    @mvtglobally

    Issue not reproducible during KI retests. (Second week)

  15. mallenexpensify commented on May 23, 2024

    @mallenexpensify
    Contributor

    @allroundexperts can you reproduce? If so, can you provide some deets, especially regarding how to put an expense on hold? If you're unable to repro, I'll close. Thx

  16. allroundexperts commented on May 26, 2024

    @allroundexperts
    Contributor

    I do see the hold option. Make sure that you have multiple manual requests in a IOU report and then open any of the request. Clicking on the three dots in the header does show up the hold option. However, after pressing it and trying to submit the report, I can not reproduce the error mentioned in the issue description.

  17. allroundexperts commented on May 26, 2024

    @allroundexperts
    Contributor

    Ref:

    Screen.Recording.2024-05-27.at.1.10.59.AM.mov
  18. mallenexpensify commented on May 29, 2024

    @mallenexpensify
    Contributor

    Thanks @allroundexperts , following your steps I was able to use Hold. Was also unable to reproduce, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineeringretest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions