Skip to content

[HOLD for payment 2024-03-14] [$500] Task - Pointer shows up for an archived task when hovering over the edge of the checkbox #37236

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.44.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing Pr #31674

Action Performed:

  1. Open ND and log in with any account
  2. Go to announce room
  3. Create a task
  4. Delete the workspace in whose announce room the task is just created
  5. Note that the task report was archived in LHN
  6. Tap task in the archived announce room
  7. Hover over the edge of the checkbox carefully

Expected Result:

No pointer should show up since the task is archived and can not be checked

Actual Result:

A pointer shows up when hovering over the edge of the checkbox

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6393369_1708984778627.pointer_bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0115fb6326c37966b2
  • Upwork Job ID: 1762247262944112640
  • Last Price Increase: 2024-02-26
  • Automatic offers:
    • ntdiary | Reviewer | 0
    • brandonhenry | Contributor | 0
    • Krishna2323 | Contributor | 0

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 26, 2024
  2. melvin-bot commented on Feb 26, 2024

    @melvin-bot
  3. changed the title [-]Task - Pointer shows up for an archived task when hovering over the edge of the checkbox[/-] [+][$500] Task - Pointer shows up for an archived task when hovering over the edge of the checkbox[/+] on Feb 26, 2024
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 26, 2024
  5. melvin-bot commented on Feb 26, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

  6. github-actions commented on Feb 26, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. melvin-bot commented on Feb 26, 2024

    @melvin-bot

    Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  8. lanitochka17 commented on Feb 26, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp
    CC @quinthar

  9. 34 remaining items

  10. melvin-bot commented on Mar 7, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Mar 7, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.48-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-03-14. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Mar 7, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ntdiary] The PR that introduced the bug has been identified. Link to the PR:
    • [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@ntdiary] Determine if we should create a regression test for this bug.
    • [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. trjExpensify commented on Mar 14, 2024

    @trjExpensify
    Contributor

    👋 @ntdiary checklist time! :)

  14. ntdiary commented on Mar 15, 2024

    @ntdiary
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ntdiary] The PR that introduced the bug has been identified. Link to the PR: Feat/categories main page #36324
    • [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/36324/files#r1526119770
    • [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
    • [@ntdiary] Determine if we should create a regression test for this bug. No need
    • [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. As shown below
    • [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

    @trjExpensify, ah, time flies. 😂 BTW, I'm still waiting to switch to NewDot for the payments. 😄

  15. trjExpensify commented on Mar 15, 2024

    @trjExpensify
    Contributor

    Haha, that it does! 🕐 Cool, I've asked Matt for an update on that quickly. If not, I can pay you via Upwork.

    In the meantime.. I don't think it's worth having a regression test for this pointer cursor. 👍 Payment summary as follows:

    $500 to @ntdiary for the C+ review
    $500 to @Krishna2323 for the fix

  16. Krishna2323 commented on Mar 18, 2024

    @Krishna2323
    Contributor

    @trjExpensify any updates here?

  17. trjExpensify commented on Mar 18, 2024

    @trjExpensify
    Contributor

    Yep, we're proceeding with Upwork for now.

    @Krishna2323 - paid
    @ntdiary - waiting for you to accept the offer. :)

  18. ntdiary commented on Mar 18, 2024

    @ntdiary
    Contributor

    Yep, we're proceeding with Upwork for now.

    @Krishna2323 - paid @ntdiary - waiting for you to accept the offer. :)

    @trjExpensify, ah, sorry, just accepted. 😂

  19. trjExpensify commented on Mar 18, 2024

    @trjExpensify
    Contributor

    Perfect, paid. Closing! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions