[HOLD for payment 2024-03-14] [$250] iOS - Image - Maximum zoom is applied after zooming out

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.44-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4345659
Email or phone of affected tester (no customers): vdargentotest+ios022624@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Pre-requisite: the user must be logged in

Go to any chat
Send an image
Tap on the image preview
Zoom in until you can not zoom more
Double tap on the image to zoom out
Try to zoom in with 2 fingers

Expected Result:

The image should be zoomed in a bit

Actual Result:

The maximum zoom is applied to the image

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6393482_1708996519041.Rpreplay_Final1708986936.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013893bd4f5612ab60
Upwork Job ID: 1762299502083756032
Last Price Increase: 2024-02-27
Automatic offers:

paultsimura | Reviewer | 0
andreasnw | Contributor | 0

Job added to Upwork: https://www.upwork.com/jobs/~013893bd4f5612ab60

@paultsimura

Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (External)

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Auto-assign attempt failed, all eligible assignees are OOO.

@quinthar

We think that this bug might ### be related to #vip-vsp
CC @quinthar

@andreasnw

cc @andreasnw @eVoloshchak I think this is related to #35931

Reviewing label has been removed, please complete the "BugZero Checklist".

@paultsimura

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.48-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: resetting pinchScale.value to 1 when double tap performed #37692

If no regressions arise, payment will be issued on 2024-03-14. 🎊

For reference, here are some details about the assignees on this issue:

@paultsimura requires payment automatic offer (Reviewer)
@andreasnw requires payment automatic offer (Contributor)

feat: Simplify native attachment gallery paging context and improve code

The PR that introduced the bug has been identified. Link to the PR: Simplify native attachment gallery paging context and improve code #36534
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/36534/files#r1524549613
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug: Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

iOS / Android:

Send an image attachment
Open the attachment and zoom in to the max using the pinch gesture
Double-tap the image to zoom out
Start zooming in again using the pinch gesture
Verify the image is being zoomed gradually

Do we agree 👍 or 👎

@slafortune

Issue is ready for payment but no BZ is assigned. @slafortune you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

@paultsimura

Testrail added here - https://github.com/Expensify/Expensify/issues/379000
@paultsimura - Paid
@andreasnw - Paid

Navigation Menu

Repository navigation

[HOLD for payment 2024-03-14] [$250] iOS - Image - Maximum zoom is applied after zooming out #37248

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

30 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-03-14] [$250] iOS - Image - Maximum zoom is applied after zooming out #37248

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Feb 27, 2024

melvin-bot commented on Feb 27, 2024

github-actions commented on Feb 27, 2024

melvin-bot commented on Feb 27, 2024

lanitochka17 commented on Feb 27, 2024

youssef-lr commented on Feb 27, 2024

30 remaining items

melvin-bot commented on Mar 7, 2024

melvin-bot commented on Mar 7, 2024

paultsimura commented on Mar 14, 2024

melvin-bot commented on Mar 14, 2024

slafortune commented on Mar 14, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions