Skip to content

[HOLD for payment 2024-03-07] [$500] Chat - The selected 2nd contact is shown in first line #37250

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.44
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4346886
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Launch app
  2. Tap on a report
  3. Enter @
  4. Select here from user suggestions
  5. Tap enter key and go to next line
  6. Enter @ and select any contact from user suggestion
  7. Note, the selected 2nd contact is shown in first line
  8. Send the message
  9. Note here message is not highlighted

Expected Result:

Selecting user suggestions here and then another contact, must show 2nd contact at second line in compose box and after sending message, here must be highlighted

Actual Result:

Selecting user suggestions here and then another contact, showing 2nd contact at first in compose box and after sending message, here is not highlighted

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6393498_1708997911772.scl.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0104f679d006807363
  • Upwork Job ID: 1762301377508782080
  • Last Price Increase: 2024-02-27

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 27, 2024
  2. changed the title [-]Chat - The selected 2nd contact is shown in first line[/-] [+][$500] Chat - The selected 2nd contact is shown in first line[/+] on Feb 27, 2024
  3. melvin-bot commented on Feb 27, 2024

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 27, 2024
  5. melvin-bot commented on Feb 27, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

  6. github-actions commented on Feb 27, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. melvin-bot commented on Feb 27, 2024

    @melvin-bot

    Auto-assign attempt failed, all eligible assignees are OOO.

  8. lanitochka17 commented on Feb 27, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp
    CC @quinthar

  9. youssef-lr commented on Feb 27, 2024

    @youssef-lr
    Contributor

    Looks like this is caused by #36792, cc @dukenv0307, reverting your PR fixed it for me locally

    Screen.Recording.2024-02-27.at.05.42.36.mov
  10. 17 remaining items

  11. changed the title [-][$500] Chat - The selected 2nd contact is shown in first line[/-] [+][HOLD for payment 2024-03-07] [$500] Chat - The selected 2nd contact is shown in first line[/+] on Feb 29, 2024
  12. melvin-bot commented on Feb 29, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Feb 29, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-03-07. 🎊

    For reference, here are some details about the assignees on this issue:

    • @mkhutornyi requires payment (Needs manual offer from BZ)
  14. abdulrahuman5196 commented on Mar 1, 2024

    @abdulrahuman5196
    Contributor

    No payment required here since it was a regression fix. @youssef-lr We can close this issue.

  15. melvin-bot commented on Mar 7, 2024

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @trjExpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  16. melvin-bot commented on Mar 7, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@trjExpensify)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1762301377508782080/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  17. removed their assignment
    on Mar 7, 2024
  18. abdulrahuman5196 commented on Mar 7, 2024

    @abdulrahuman5196
    Contributor

    No payment required here since it was a regression fix. youssef-lr We can close this issue.

    cc: @trjExpensify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions