Skip to content

[HOLD for payment 2024-03-07] [$125] Web - Thread - Console error shows up when opening message in thread #37253

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.44-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to any chat
  3. Send a message
  4. Right click on the message > Reply in thread

Expected Result:

No console error will show up

Actual Result:

Console error shows up when opening message in thread

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6393509_1708999870296.bandicam_2024-02-27_06-35-39-042.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fd70450a1c9c7c93
  • Upwork Job ID: 1762304222689734656
  • Last Price Increase: 2024-02-27
  • Automatic offers:
    • dukenv0307 | Contributor | 0

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 27, 2024
  2. changed the title [-]Web - Thread - Console error shows up when opening message in thread[/-] [+][$500] Web - Thread - Console error shows up when opening message in thread[/+] on Feb 27, 2024
  3. melvin-bot commented on Feb 27, 2024

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 27, 2024
  5. melvin-bot commented on Feb 27, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

  6. github-actions commented on Feb 27, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. melvin-bot commented on Feb 27, 2024

    @melvin-bot

    Triggered auto assignment to @techievivek (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  8. lanitochka17 commented on Feb 27, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp
    CC @quinthar

  9. 31 remaining items

  10. MitchExpensify commented on Mar 9, 2024

    @MitchExpensify
    Contributor

    Payment summary:

    C+: $125 @sobitneupane (NewDot)
    C: $125 @dukenv0307 (Upwork)

    I couldn't find any older contract for you @dukenv0307 so I created this job, let me know when you've accepted the offer and I'll issue payment 🙇 https://www.upwork.com/jobs/~016662aefe6aa80518

  11. techievivek commented on Mar 12, 2024

    @techievivek
    Contributor

    Not overdue, we are issuing the payments. CC @MitchExpensify

  12. dukenv0307 commented on Mar 12, 2024

    @dukenv0307
    Contributor

    @youssef-lr @techievivek Hi I see after this comment, you've downgraded the issue bounty to $125, I assume that's because the change suggested is tiny, just adding the ? to avoid undefined object access.

    However that "quick change" is a workaround. The root cause and solution of this issue is actually different and more complex (see here), and that's what we went with to fix the issue (with urgency as it was a deploy blocker).

    Could we honor the original bounty ($500) for the issue since it was not dead simple as initially suggested?

  13. MitchExpensify commented on Mar 12, 2024

    @MitchExpensify
    Contributor

    Waiting on @dukenv0307 to accept the offer in order to pay 🙇

  14. youssef-lr commented on Mar 12, 2024

    @youssef-lr
    Contributor

    @dukenv0307 I think I lowered the bounty due to this being just a console error and it's not really affecting the user. Do you think the console error is a smoke for an actual bug in the UI that is noticeable by the user?

  15. MitchExpensify commented on Mar 17, 2024

    @MitchExpensify
    Contributor

    Bump on accepting this offer as a next step @dukenv0307 https://www.upwork.com/nx/wm/offer/101299289

  16. dukenv0307 commented on Mar 18, 2024

    @dukenv0307
    Contributor

    @dukenv0307 I think I lowered the bounty due to this being just a console error and it's not really affecting the user

    Thanks for the explanation.

    Bump on accepting this offer as a next step @dukenv0307 https://www.upwork.com/nx/wm/offer/101299289

    @MitchExpensify I accepted, thank you!

  17. MitchExpensify commented on Mar 19, 2024

    @MitchExpensify
    Contributor

    Paid and contract ended 🙇

  18. sobitneupane commented on Mar 21, 2024

    @sobitneupane
    Contributor

    Requested payment in newDot.

    Payment Summary: #37253 (comment)

  19. JmillsExpensify commented on Mar 22, 2024

    @JmillsExpensify
    Contributor

    $125 approved for @sobitneupane based on summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions