Skip to content

[HOLD for payment 2024-03-07] [$500] Workspace - Default currency is clickable as a workspace member and it leads to error page #37288

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.44-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • User is invited as a member of a workspace.
  1. Go to staging.new.expensify.com.
  2. Log in as workspace member.
  3. Open workspace settings.
  4. Click on the workspace in which user is a member.
  5. Click Currency.

Expected Result:

Currency should not be clickable, since workspace member will not be able to edit the workspace currency.

Actual Result:

Currency is clickable, which leads to an error page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6393826_1709031183198.20240227_074229.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fc2eec63f826c791
  • Upwork Job ID: 1762473973362655232
  • Last Price Increase: 2024-02-27

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 27, 2024
  2. changed the title [-]Workspace - Default currency is clickable as a workspace member and it leads to error page[/-] [+][$500] Workspace - Default currency is clickable as a workspace member and it leads to error page[/+] on Feb 27, 2024
  3. melvin-bot commented on Feb 27, 2024

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 27, 2024
  5. melvin-bot commented on Feb 27, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

  6. github-actions commented on Feb 27, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. melvin-bot commented on Feb 27, 2024

    @melvin-bot

    Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  8. kbecciv commented on Feb 27, 2024

    @kbecciv
    Author

    We think that this bug might be related to #wave5-free-submitters
    CC @dylanexpensify

  9. 16 remaining items

  10. changed the title [-][$500] Workspace - Default currency is clickable as a workspace member and it leads to error page[/-] [+][HOLD for payment 2024-03-07] [$500] Workspace - Default currency is clickable as a workspace member and it leads to error page[/+] on Feb 29, 2024
  11. melvin-bot commented on Feb 29, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Feb 29, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-03-07. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Pujan92 requires payment (Needs manual offer from BZ)
  13. melvin-bot commented on Mar 7, 2024

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @sonialiap you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  14. melvin-bot commented on Mar 7, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    • ROLE: @Pujan92 paid $(AMOUNT) via Upwork (LINK)

    BugZero Checklist (@sonialiap)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1762473973362655232/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  15. sonialiap commented on Mar 12, 2024

    @sonialiap
    Contributor

    @Pujan92 sorry I missed this last week, it didn't come up in my search

    @Pujan92 Reviewer $500 offer sent
    ruben-rebelo - callstack, no payment needed

  16. Pujan92 commented on Mar 12, 2024

    @Pujan92
    Contributor

    Np, accepted the offer :)

  17. sonialiap commented on Mar 12, 2024

    @sonialiap
    Contributor

    Payment sent 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions