Skip to content

[HOLD for payment 2024-03-07] [$500] Bank account - Selected bank account is not checked in bank account selection step #37290

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.44-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal team

Action Performed:

  1. Go to staging.new.expensify.com.
  2. Go to workspace settings.
  3. Select a workspace.
  4. Go to Bank account.
  5. Click Connect online with Paid.
  6. Log in with Chase account.
  7. Back in bank account selection page, select any bank account.

Expected Result:

The selected bank account is checked in the checkbox.

Actual Result:

The selected bank account is not checked in the checkbox.
This issue also occurs with the checkbox in Company owner steps.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6393828_1709031318790.20240227_074738.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f67808490772984d
  • Upwork Job ID: 1762476893193760768
  • Last Price Increase: 2024-02-27
  • Automatic offers:
    • jjcoffee | Reviewer | 0
    • ZhenjaHorbach | Contributor | 0

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 27, 2024
  2. changed the title [-]Bank account - Selected bank account is not checked in bank account selection step[/-] [+][$500] Bank account - Selected bank account is not checked in bank account selection step[/+] on Feb 27, 2024
  3. melvin-bot commented on Feb 27, 2024

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 27, 2024
  5. melvin-bot commented on Feb 27, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

  6. github-actions commented on Feb 27, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. melvin-bot commented on Feb 27, 2024

    @melvin-bot

    Triggered auto assignment to @flodnv (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  8. kbecciv commented on Feb 27, 2024

    @kbecciv
    Author

    We think that this bug might be related to #vip-bills
    CC @davidcardoza

  9. 23 remaining items

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Feb 29, 2024
  11. changed the title [-][$500] Bank account - Selected bank account is not checked in bank account selection step[/-] [+][HOLD for payment 2024-03-07] [$500] Bank account - Selected bank account is not checked in bank account selection step[/+] on Feb 29, 2024
  12. melvin-bot commented on Feb 29, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Feb 29, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-03-07. 🎊

    For reference, here are some details about the assignees on this issue:

  14. jjcoffee commented on Mar 7, 2024

    @jjcoffee
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR: Mandatory exit survey for users going back to OldDot #34925
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/34925/files#r1515894840
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • Determine if we should create a regression test for this bug. Yes
    • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Proposal

    1. Go to workspace settings
    2. Select a workspace
    3. Go to Bank account
    4. Click Connect online with Paid
    5. Log in with Chase test account details
    6. Back in bank account selection page, select any bank account
    7. Verify that selected bank account is checked in the checkbox

    Do we agree 👍 or 👎

  15. melvin-bot commented on Mar 7, 2024

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @Christinadobrzyn you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  16. Christinadobrzyn commented on Mar 7, 2024

    @Christinadobrzyn
    Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions