Skip to content

[LOW][$500] LHN – Chat in LHN in not bold if receive a second IOU from new user #37315

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.44-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4343092
Issue reported by: Applause - Internal team

Action Performed:

Preconditions:
2 accounts are needed for this test, 1 logged in the main testing account and the second in a secondary device or browser.
Both accounts should NOT have a existing conversation.

  1. Go to https://staging.new.expensify.com/
  2. Secondary device - Send a request money to the account in the main testing device. Make sure they don't have a existing conversation
  3. Navigate to LHN
  4. Verify the conversation is marked as unread
  5. Navigate to the conversation
  6. Navigate back to LHN (mobile) or to another conversation (Web/Desktop)
  7. Verify the conversation is marked as read in LHN
  8. Secondary device - Send another money request to the same account
  9. Navigate to LHN

Expected Result:

The conversation is marked as unread after a new request was made

Actual Result:

The conversation is marked as read after a new request was made

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6394156_1709045670737.Screenrecorder-2024-02-27-11-24-06-158.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014f4d3cd1fd4967db
  • Upwork Job ID: 1762606281591746560
  • Last Price Increase: 2024-03-04
  • Automatic offers:
    • getusha | Reviewer | 0
    • FitseTLT | Contributor | 0
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 27, 2024
  2. melvin-bot commented on Feb 27, 2024

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. kbecciv commented on Feb 27, 2024

    @kbecciv
    Author

    @mallenexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. added
    InternalRequires API changes or must be handled by Expensify staff
    on Feb 27, 2024
  5. melvin-bot commented on Feb 27, 2024

    @melvin-bot
  6. melvin-bot commented on Feb 27, 2024

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @getusha (Internal)

  7. mallenexpensify commented on Feb 27, 2024

    @mallenexpensify
    Contributor

    @getusha do you think this can be external?
    Adding to #vip-split project.

  8. getusha commented on Mar 3, 2024

    @getusha
    Contributor

    @mallenexpensify i think this can go external

    cc @rlinoz looks like related to #36276

  9. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    InternalRequires API changes or must be handled by Expensify staff
    on Mar 4, 2024
  10. 132 remaining items

  11. mallenexpensify commented on Feb 12, 2025

    @mallenexpensify
    Contributor

    Thanks @FitseTLT , one more thing....
    In the examples above, it's User A and User B. And, in the title it says Splits. Wouldn't this bug/new feature exist if I'm an employee (User A) and submit to my boss (User B)? I feel like this isn't just, only, for splitting.

  12. mallenexpensify commented on Feb 12, 2025

    @mallenexpensify
    Contributor

    @dannymcclain please hold on reviewing til we have a better idea of next steps.

  13. dannymcclain commented on Feb 12, 2025

    @dannymcclain
    Contributor

    @mallenexpensify This feels more like a bug to me than a new feature? Shouldn't a new request always mark the chat as unread no matter what type of request?

  14. FitseTLT commented on Feb 12, 2025

    @FitseTLT
    Contributor

    @mallenexpensify This feels more like a bug to me than a new feature? Shouldn't a new request always mark the chat as unread no matter what type of request?

    Nope @dannymcclain we only mark a chat as unread when new message/report action is created but we only create a new report preview report action for a new expense if there is no open expense/iou report in the chat. If there is a report that is not paid out then a new expense will be added to to that report and new message is only created for the iou/expense report not for the chat report.

    I feel like this isn't just, only, for splitting.

    @mallenexpensify Though the title says split the testing steps clearly show that it isn't so it is better to remove the Splits from the title 👍 This issue applies to both iou and expense reports.

  15. changed the title [-][LOW] [Splits] [$500] LHN – Chat in LHN in not bold if receive a second IOU from new user[/-] [+][LOW][$500] LHN – Chat in LHN in not bold if receive a second IOU from new user[/+] on Feb 14, 2025
  16. mallenexpensify commented on Feb 14, 2025

    @mallenexpensify
    Contributor

    Thanks @FitseTLT.
    @getusha and @FitseTLT , what do you propose is the best next step here? There are a lot of comments here. Do we want to update the logic so that we're marking a chat as unread if this action?

    new report preview report action for a new expense if there is no open expense/iou report in the chat.

  17. FitseTLT commented on Feb 14, 2025

    @FitseTLT
    Contributor

    I think the best next step is to start a slack convo. I will do it on Monday if you are ok with it 👍

  18. mallenexpensify commented on Feb 15, 2025

    @mallenexpensify
    Contributor

    Please do @FitseTLT , post in #expensify-open-source and tag all assigned folks on this issue. Thx

  19. FitseTLT commented on Feb 20, 2025

    @FitseTLT
    Contributor
  20. mallenexpensify commented on Feb 26, 2025

    @mallenexpensify
    Contributor

    From convo in Slack, going to close.

    Image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

EngineeringInternalRequires API changes or must be handled by Expensify staffNewFeatureSomething to build that is a new item.WeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions