IOU - LHN for IOU report still shows the requested amount when IOU is deleted

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v1.4.44-0
Reproducible in staging?: y
Reproducible in production?: y
Issue reported by: Applause - Internal Team
Issue found when executing PR: #36557

Action Performed:

Go to staging.new.expensify.com
Go to 1:1 DM.
Create a manual request.
Go to request details page.
Send a message.
Click 3-dot menu > Delete request.
Return to IOU report.

Expected Result:

LHN for IOU report will show [Deleted request].

Actual Result:

LHN for IOU report still shows the requested amount when IOU is deleted.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6394391_1709056655937.bandicam_2024-02-27_06-57-33-774.mp4

View all open jobs on GitHub

@stephanieelliott

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@stephanieelliott

@stephanieelliott I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@davidcardoza

We think that this bug might be related to #vip-bills
CC @davidcardoza

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU - LHN for IOU report still shows the requested amount when IOU is deleted

What is the root cause of that problem?

In here we do not check if the action is deleted or not, so that leads to the bug.

What changes do you think we should make in order to solve the problem?

We need to add check if the action is deleted in that case. If true, display [Deleted request] instead. Do it by adding to here:

        if(ReportActionsUtils.isDeletedAction(reportAction) && ReportActionsUtils.isTransactionThread(reportAction)){
            return Localize.translateLocal('parentReportAction.deletedRequest')
        }

or use isDeletedParentAction rather than isDeletedAction

Also, we need to consider the case isReversedTransaction(reportAction): true

What alternative solutions did you explore? (Optional)

NA

@stephanieelliott

@stephanieelliott Eep! 4 days overdue now. Issues have feelings too...

I don't really think this is a bug, as long as the X owes Y 0.00 stays current, it's not unexpected that the LHN shows the most recent request made (even if it was deleted afterward). I'm not sure if it was a conscious UI decision or something that wasn't given consideration, but I don't think we need to prioritize updating this behavior.

Navigation Menu

Repository navigation

IOU - LHN for IOU report still shows the requested amount when IOU is deleted #37333

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

IOU - LHN for IOU report still shows the requested amount when IOU is deleted #37333

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Feb 27, 2024

kbecciv commented on Feb 27, 2024

kbecciv commented on Feb 27, 2024

dukenv0307 commented on Feb 28, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Mar 4, 2024

stephanieelliott commented on Mar 5, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions