Skip to content

Expense - Transaction thread with violation does not appear in LHN #37405

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Found when validating PR : #35449

Version Number: v1.4.44-7
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team

Action Performed:

Precondition:

  • User is an employee of Collect workspace.
  • The Collect workspace has Category and Tag set to "Required".
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create a manual request without category and tag.

Expected Result:

The transaction thread with violation will appear in LHN.

Actual Result:

The transaction thread with violation does not appear in LHN unless it is visited.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6395021_1709091888120.bandicam_2024-02-28_02-49-56-207.mp4

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 28, 2024
  2. melvin-bot commented on Feb 28, 2024

    @melvin-bot

    Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. izarutskaya commented on Feb 28, 2024

    @izarutskaya
    Author

    @MitchExpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  4. izarutskaya commented on Feb 28, 2024

    @izarutskaya
    Author

    We think that this bug might be related to #wave6-collect-submitters
    CC @greg-schroeder

  5. MitchExpensify commented on Mar 2, 2024

    @MitchExpensify
    Contributor

    This does look like wave 6 to me too, what do you think @greg-schroeder ?

  6. MitchExpensify commented on Mar 5, 2024

    @MitchExpensify
    Contributor

    Not sure how the quarterly release impacts this issue's priority, I still think confirming if its a wave 6 related issue is a good first step so bumpin ya for an opinion there @greg-schroeder

  7. melvin-bot commented on Mar 8, 2024

    @melvin-bot

    @MitchExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  8. MitchExpensify commented on Mar 10, 2024

    @MitchExpensify
    Contributor

    Wave collect worthy Señor Wave Collect, @trjExpensify ?

  9. 10 remaining items

  10. github-actions commented on Mar 13, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  11. melvin-bot commented on Mar 13, 2024

    @melvin-bot

    Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  12. izarutskaya commented on Mar 13, 2024

    @izarutskaya
    Author

    @danieldoglas I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors. Thanks

  13. danieldoglas commented on Mar 13, 2024

    @danieldoglas
    Contributor

    @cead22 I remember you said you found new issues with violations last Friday. Is this related?

  14. luacmartins commented on Mar 13, 2024

    @luacmartins
    Contributor

    I don't think this is a blocker since Violations is still in a beta. Additionally, I think this might be because we reverted this PR due to performance issues since that PR added report errors to the LHN.

  15. melvin-bot commented on Mar 13, 2024

    @melvin-bot

    @danieldoglas @MitchExpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  16. cead22 commented on Mar 14, 2024

    @cead22
    Contributor

    I couldn't repro on v1.4.52-1 staging desktop web

    1wBjJrPYLE.mp4
  17. self-assigned this
    on Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions