Repository navigation
[$500] Workspace - The invite message can't fit into the textbox #37406
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Found when validating PR : #29991
Version Number: 1.4.44.0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal Team
Action Performed:
- Log in with a Gmail account
- Create a new workspace
- Tap on the "Invite members" button
- Select any suggested member
- Tap on the Invite button
Expected Result:
The invite message should fit into the textbox.
Actual Result:
The invite message can't fit into the textbox.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01561b4140b01dff6c
- Upwork Job ID: 1763716186253737984
- Last Price Increase: 2024-03-02
Activity
melvin-bot commentedon Feb 28, 2024
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.izarutskaya commentedon Feb 28, 2024
@mallenexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
izarutskaya commentedon Feb 28, 2024
We think that this bug might be related to #wave8-collect-admins
CC @zanyrenney
[-]Workspace - The invite message can't fit into the textbox[/-][+][$500] Workspace - The invite message can't fit into the textbox[/+]melvin-bot commentedon Mar 2, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01561b4140b01dff6c
melvin-bot commentedon Mar 2, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (
External)mallenexpensify commentedon Mar 2, 2024
Think it can be external. @paultsimura , let me know if you disagree.
Checking with Wave 6, collect submitter for project
https://expensify.slack.com/archives/C02MW39LT9N/p1709337922878799
11 remaining items
paultsimura commentedon Mar 4, 2024
Just duplicate your invite message to make it 2x as long
dukenv0307 commentedon Mar 4, 2024
@paultsimura I think the problem here is that the "default invite message" is clipped when it's shown to the user, it's supposed to always be showing in full when the user opens that page (if not the user will have to scroll to read the full text). The current
max heightwas set based on that assumption too.If the user edits the invite message and it becomes longer than the text box, it's not a problem because at the time the user already reads the full text of the "default invite message"
paultsimura commentedon Mar 4, 2024
From what I see – we have this message scrollable on all platforms. Could you please share the recordings on what platforms the message is not scrollable?
paultsimura commentedon Mar 4, 2024
If I modify the message, leave the page, and go back to it – the new custom message will be "default" for all future invitations. So this is not necessarily related to the default invitation message set by Expensify.
Screen.Recording.2024-03-04.at.12.50.31.mov
paultsimura commentedon Mar 4, 2024
@godofoutcasts94 please try to keep the communication productive. From what I see, all the platforms (including both mWeb) already have this field scrollable. If you have a different experience - please provide the screen recording.
paultsimura commentedon Mar 4, 2024
@shawnborton just so you don't have to scroll through all the messages.
TD;DR:
The issue is that the welcome message is taller than the defined max height, and the message can be of any height, so there's no sense to just increase the max height to some other fixed value.
However, the field is scrollable. Do we want to change this behavior? And if yes – what would be the expected outcome?
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-03-02.at.12.43.51.mp4
#37406 (comment)
#37406 (comment)
dannymcclain commentedon Mar 4, 2024
I'm down to wait for the other designers to chime in, but I think this is expected behavior and isn't something we need to do anything about. Looks to be working like a normal
textareainput, which I think is a good and fine thing.@mallenexpensify I think it kinda depends on whether the field is focused or not. If the field is focused, we should continue to default to the end/bottom, because that's where we place your cursor in the input (I assume). If the field is not focused, then I could see an argument for defaulting to the top of the message, but honestly think either is fine.
shawnborton commentedon Mar 4, 2024
Yeah I agree with Danny here - this seems to be standard textarea behavior.
Did we recently change the max height or something?
paultsimura commentedon Mar 4, 2024
Nope. I think the issue reporter just had a relatively small screen and a relatively long workspace name, so the default message overflowed the pre-defined textarea height.
So would you suggest to close this issue? @shawnborton @dannymcclain
shawnborton commentedon Mar 4, 2024
I would be good with that, yes.
mallenexpensify commentedon Mar 4, 2024
Thanks all, closing