Skip to content

[HOLD for payment 2024-03-20] [$500] Settings - I get an "about:blank" page after navigating to the macOS link #37407

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Found when executing PR : #29991

Version Number: 1.4.44.0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal Team

Action Performed:

  1. Navigate to Settings - About - App download links - macOS
  2. Tap on the "X" button

Expected Result:

I should be returned to Expensify after tapping on the "X" buttor or I should be able to use the back button to navigate back.

Actual Result:

I get an "about:blank" page after navigating to the macOS link. I can't use the browsers back button.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6395100_1709099144625.BMDX3142.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0175806b466ff4d5e7
  • Upwork Job ID: 1764768337906176000
  • Last Price Increase: 2024-03-04

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 28, 2024
  2. melvin-bot commented on Feb 28, 2024

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. izarutskaya commented on Feb 28, 2024

    @izarutskaya
    Author

    @sakluger I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  4. izarutskaya commented on Feb 28, 2024

    @izarutskaya
    Author

    We think that this bug might be related to #wave8-collect-admins
    CC @zanyrenney

  5. sakluger commented on Feb 29, 2024

    @sakluger
    Contributor

    I agree this is a bug, since on the mobile app, we close the browser tab after clicking x.

    I would say that this is #vip-vsb, I'll add to that dashboard as low priority.

  6. melvin-bot commented on Mar 4, 2024

    @melvin-bot

    @sakluger Whoops! This issue is 2 days overdue. Let's get this updated quick!

  7. sakluger commented on Mar 4, 2024

    @sakluger
    Contributor

    I'm going to go ahead and make this external - if it must be handled internally, let me know.

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 4, 2024
  9. 27 remaining items

  10. changed the title [-][$500] Settings - I get an "about:blank" page after navigating to the macOS link[/-] [+][HOLD for payment 2024-03-20] [$500] Settings - I get an "about:blank" page after navigating to the macOS link[/+] on Mar 13, 2024
  11. melvin-bot commented on Mar 13, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Mar 13, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-03-20. 🎊

    For reference, here are some details about the assignees on this issue:

    • @allroundexperts requires payment through NewDot Manual Requests
    • @tienifr requires payment (Needs manual offer from BZ)
  13. melvin-bot commented on Mar 13, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
    • [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@allroundexperts] Determine if we should create a regression test for this bug.
    • [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. melvin-bot commented on Mar 20, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@sakluger)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1764768337906176000/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  15. sakluger commented on Mar 20, 2024

    @sakluger
    Contributor

    @allroundexperts could you please complete the BZ checklist?

    @tienifr I sent you an offer through Upwork, please let me know when you've accepted it. Thanks!

  16. tienifr commented on Mar 21, 2024

    @tienifr
    Contributor

    @sakluger I accepted the offer, thanks!

  17. allroundexperts commented on Mar 21, 2024

    @allroundexperts
    Contributor

    Checklist

    1. Fix: Safari App Store Link Redirect #11110
    2. https://github.com/Expensify/App/pull/11110/files#r1534762717
    3. N/A
    4. A regression test would be helpful here. The steps given in the OP look good enough to me.
  18. sakluger commented on Mar 22, 2024

    @sakluger
    Contributor

    Thanks @tienifr - all paid out.

    @allroundexperts feel free to request payment via newdot.

  19. JmillsExpensify commented on Apr 1, 2024

    @JmillsExpensify
    Contributor

    $500 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions