Skip to content

[HOLD for payment 2024-03-14] [$500] Category - No spacing between long category name and category status #37417

New issue
New issue
Closed
Closed
[HOLD for payment 2024-03-14] [$500] Category - No spacing between long category name and category status#37417
Assignees
puneetlathOllywsdragnoir
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@izarutskaya
izarutskaya
opened on Feb 28, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Found when validating PR : #36324

Version Number: v1.4.44-7
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:

Action Performed:

Precondition:

  • Collect workspace has a long category name.
  1. Log in to New Dot as admin.
  2. Go to workspace settings > Collect workspace.
  3. Go to Categories.

Expected Result:

There will be spacing between the long category name and category status.

Actual Result:

There is no spacing between the long category name and category status.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6395224_1709111519336!Screenshot_20240228-130857_New_Expensify__1_

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014c7dcc9cd5ddc2d3
  • Upwork Job ID: 1762812215508320256
  • Last Price Increase: 2024-02-28
  • Automatic offers:
    • Ollyws | Reviewer | 0

Activity

  1. izarutskaya
    added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 28, 2024
  2. melvin-bot
    changed the title [-]Category - No spacing between long category name and category status[/-] [+][$500] Category - No spacing between long category name and category status[/+] on Feb 28, 2024

  3. melvin-bot commented on Feb 28, 2024

    @melvin-bot
    melvin-botBot
    on Feb 28, 2024 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~014c7dcc9cd5ddc2d3

  4. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 28, 2024
  5. melvin-bot
    assigned
    Ollyws
    on Feb 28, 2024

  6. melvin-bot commented on Feb 28, 2024

    @melvin-bot
    melvin-botBot
    on Feb 28, 2024 – with Melvin Bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

  7. melvin-bot
    assigned
    puneetlath
    on Feb 28, 2024

  8. melvin-bot commented on Feb 28, 2024

    @melvin-bot
    melvin-botBot
    on Feb 28, 2024 – with Melvin Bot

    Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  9. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Feb 28, 2024

  10. github-actions commented on Feb 28, 2024

    @github-actions
    github-actionsBot
    on Feb 28, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  11. 26 remaining items

  12. melvin-bot
    changed the title [-][$500] Category - No spacing between long category name and category status[/-] [+][HOLD for payment 2024-03-14] [$500] Category - No spacing between long category name and category status[/+] on Mar 7, 2024
  13. melvin-bot
    removed
    ReviewingHas a PR in review
    on Mar 7, 2024

  14. melvin-bot commented on Mar 7, 2024

    @melvin-bot
    melvin-botBot
    on Mar 7, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Mar 7, 2024

    @melvin-bot
    melvin-botBot
    on Mar 7, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.48-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-03-14. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on Mar 7, 2024

    @melvin-bot
    melvin-botBot
    on Mar 7, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
    • [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@Ollyws] Determine if we should create a regression test for this bug.
    • [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  17. puneetlath commented on Mar 12, 2024

    @puneetlath
    puneetlath
    on Mar 12, 2024
    Contributor

    @Ollyws friendly reminder about the checklist so we can pay in a couple days.

  18. Ollyws commented on Mar 13, 2024

    @Ollyws
    Ollyws
    on Mar 13, 2024
    Contributor

    BugZero Checklist:

    • The PR that introduced the bug has been identified. Link to the PR:

    #36324

    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    #36324 (comment)

    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    N/A

    • Determine if we should create a regression test for this bug.

    Yes

    • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition: Collect workspace has a long category name.

1. Log in to New Dot as admin.
2. Go to workspace settings > Collect workspace.
3. Go to Categories.
4. Verify that there is padding between the category name and category status

    Do we agree 👍 or 👎

  19. puneetlath commented on Mar 14, 2024

    @puneetlath
    puneetlath
    on Mar 14, 2024
    Contributor

    Thanks. @Ollyws @dragnoir offers to both of you are pending. Please ping on this issue once you've accepted.

  20. dragnoir commented on Mar 14, 2024

    @dragnoir
    dragnoir
    on Mar 14, 2024
    Contributor

    Thank you @puneetlath offer accepted, also pls check here #37668 (comment)

  21. puneetlath commented on Mar 14, 2024

    @puneetlath
    puneetlath
    on Mar 14, 2024
    Contributor

    @dragnoir has been paid.

    @Ollyws ping me here when you've accepted the offer.

  22. Ollyws commented on Mar 14, 2024

    @Ollyws
    Ollyws
    on Mar 14, 2024
    Contributor

    @puneetlath accepted, thanks!

  23. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Mar 14, 2024

  24. puneetlath commented on Mar 14, 2024

    @puneetlath
    puneetlath
    on Mar 14, 2024
    Contributor

    All paid. Thanks y'all!

  25. puneetlath
    closed this as completedon Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions