Skip to content

[HOLD for payment 2024-03-13] [$125] Room - Workspace room settings shows Visibility row with newRoomPage.visibilityOptions.null. #37445

New issue
New issue
Closed
Closed
[HOLD for payment 2024-03-13] [$125] Room - Workspace room settings shows Visibility row with newRoomPage.visibilityOptions.null.#37445
Assignees
MonilBhavsarkadiealexandereh2077apeyada
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Description

@lanitochka17
lanitochka17
opened on Feb 28, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.44-11
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a new workspace
  3. Do not go to workspace chat (very important)
  4. Go offline
  5. Go to FAB > Request money > Manual
  6. Enter amount > Next
  7. Select the new workspace in Step 1
  8. Click on the workspace under "To"
  9. Go to Settings

Expected Result:

Workspace room settings will not show Visibility row

Actual Result:

Workspace room settings shows Visibility row with newRoomPage.visibilityOptions.null.
This issue only occurs when the workspace room has not been visited

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6395926_1709140787566.20240228_234931.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0122cd4185dcaeff62
  • Upwork Job ID: 1763061326536376320
  • Last Price Increase: 2024-03-01
  • Automatic offers:
    • eh2077 | Reviewer | 0

Activity

  1. lanitochka17
    added
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 28, 2024

  2. melvin-bot commented on Feb 28, 2024

    @melvin-bot
    melvin-botBot
    on Feb 28, 2024 – with Melvin Bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot
    assigned
    kadiealexander
    on Feb 28, 2024

  4. lanitochka17 commented on Feb 28, 2024

    @lanitochka17
    lanitochka17
    on Feb 28, 2024
    Author

    We think that this bug might be related to #vip-vsp
    CC @quinthar

  5. lanitochka17 commented on Feb 28, 2024

    @lanitochka17
    lanitochka17
    on Feb 28, 2024
    Author

    @kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  6. apeyada commented on Feb 28, 2024

    @apeyada
    apeyada
    on Feb 28, 2024
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Room - Workspace room settings shows Visibility row with newRoomPage.visibilityOptions.null

    What is the root cause of that problem?

    This happens when report.visibility = null, meets this condition:

    App/src/pages/settings/Report/ReportSettingsPage.tsx

    Line 146 in fe6d902

    {report?.visibility !== undefined &&

    What changes do you think we should make in order to solve the problem?

    update condition to !!report?.visibility &&

  7. allgandalf commented on Feb 28, 2024

    @allgandalf
    allgandalf
    on Feb 28, 2024
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Workspace room settings shows Visibility row with newRoomPage.visibilityOptions.null

    What is the root cause of that problem?

    This happens because when we are offline the visibility is returned as null but we return false only when it is undefined.

    App/src/pages/settings/Report/ReportSettingsPage.tsx

    Line 146 in fe6d902

    {report?.visibility !== undefined &&

    What changes do you think we should make in order to solve the problem?

    We need to update the condition to report?.visibility ?? false.

    Note: !!report?.visibility doesn't give any fallback value and hence can cause regression

    What alternative solutions did you explore? (Optional)

    N/A

  8. kadiealexander
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 29, 2024

  9. melvin-bot commented on Feb 29, 2024

    @melvin-bot
    melvin-botBot
    on Feb 29, 2024 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~0122cd4185dcaeff62

  10. melvin-bot
    changed the title [-]Room - Workspace room settings shows Visibility row with newRoomPage.visibilityOptions.null.[/-] [+][$500] Room - Workspace room settings shows Visibility row with newRoomPage.visibilityOptions.null.[/+] on Feb 29, 2024
  11. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 29, 2024
  12. melvin-bot
    assigned
    eh2077
    on Feb 29, 2024

  13. melvin-bot commented on Feb 29, 2024

    @melvin-bot
    melvin-botBot
    on Feb 29, 2024 – with Melvin Bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

  14. kadiealexander
    added this to [#whatsnext] #vip-vsbon Feb 29, 2024

  15. 21 remaining items

  16. melvin-bot
    changed the title [-][$125] Room - Workspace room settings shows Visibility row with newRoomPage.visibilityOptions.null.[/-] [+][HOLD for payment 2024-03-13] [$125] Room - Workspace room settings shows Visibility row with newRoomPage.visibilityOptions.null.[/+] on Mar 6, 2024

  17. melvin-bot commented on Mar 6, 2024

    @melvin-bot
    melvin-botBot
    on Mar 6, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  18. melvin-bot
    removed
    ReviewingHas a PR in review
    on Mar 6, 2024

  19. melvin-bot commented on Mar 6, 2024

    @melvin-bot
    melvin-botBot
    on Mar 6, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-03-13. 🎊

    For reference, here are some details about the assignees on this issue:

  20. melvin-bot commented on Mar 6, 2024

    @melvin-bot
    melvin-botBot
    on Mar 6, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@eh2077] The PR that introduced the bug has been identified. Link to the PR:
    • [@eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@eh2077] Determine if we should create a regression test for this bug.
    • [@eh2077] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  21. eh2077 commented on Mar 11, 2024

    @eh2077
    eh2077
    on Mar 11, 2024
    Contributor

    Checklist

    • The PR that introduced the bug has been identified.
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/35321/files#r1519481605
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a
    • Determine if we should create a regression test for this bug: I think we don't need to add a regression test for this bug. It was introduced during TS migration and the fix is straightfoward.

    cc @kadiealexander

  22. kadiealexander
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Mar 12, 2024
  23. melvin-bot
    added
    DailyKSv2
    and removed
    DailyKSv2
    on Mar 13, 2024

  24. kadiealexander commented on Mar 13, 2024

    @kadiealexander
    kadiealexander
    on Mar 13, 2024
    Contributor

    Payouts due:

    Upwork job is here.

  25. youssef-lr commented on Mar 13, 2024

    @youssef-lr
    youssef-lr
    on Mar 13, 2024
    Contributor

    @kadiealexander this was changed to $125

  26. kadiealexander commented on Mar 13, 2024

    @kadiealexander
    kadiealexander
    on Mar 13, 2024
    Contributor

    Whoops, typo! Updated.

    @apeyada please let me know when you've accepted the contract I sent across.

  27. kadiealexander
    closed this as completedon Mar 14, 2024
  28. github-project-automation
    moved this to CRITICAL in [#whatsnext] #vip-vsbon Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions