Repository navigation
[HOLD for payment 2024-03-14] Chat - Console error shows up when sending message with mention or text #37463
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.45-0
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
- Go to staging.new.expensify.com
- Go to any chat.
- Send a message with mention or emoji.
Expected Result:
No console error will show up.
Actual Result:
Console error shows up.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Activity
melvin-bot commentedon Feb 29, 2024
Triggered auto assignment to @anmurali (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.github-actions commentedon Feb 29, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Feb 29, 2024
Triggered auto assignment to @MonilBhavsar (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.m-natarajan commentedon Feb 29, 2024
We (Applause) this bug might be related to #vip-vsb
cc @quinthar
m-natarajan commentedon Feb 29, 2024
@MonilBhavsar FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
MonilBhavsar commentedon Feb 29, 2024
Discussing it here
https://expensify.slack.com/archives/C01GTK53T8Q/p1709208081154149
MonilBhavsar commentedon Feb 29, 2024
Most probably not a blocker.
To fix the issue we have two options -
react-native-reanimatedthat was updated here [New Architecture] Upgradereact-native-reanimated#36404react-native-reanimated. Ifnode.childrenis not an array, we break https://github.com/software-mansion/react-native-reanimated/blob/06231465a93e7650f0c4c66035f48dcadbe2467a/src/reanimated2/layoutReanimation/web/domUtils.ts#L17026 remaining items
MonilBhavsar commentedon Mar 8, 2024
Ah okay! Given a version bump, I think $125 is a fair amount. Do you agree?
mkhutornyi commentedon Mar 8, 2024
Not sure if this is special case but I am seeing that flatten internal review fee applied in other issues.
i.e. #35999 (comment) for svg version bump
Though, I am happy with whatever team decides.
mkhutornyi commentedon Mar 11, 2024
Another instance: #36187 (comment)
This is also reanimated version bump and even same as our case.
melvin-bot commentedon Mar 14, 2024
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
anmurali commentedon Mar 18, 2024
@MonilBhavsar what do you think here? I believe I need to create a manual Upwork offer to pay @mkhutornyi based on the final amount you decide!
MonilBhavsar commentedon Mar 21, 2024
Given recent discussion on bounties https://expensify.slack.com/archives/CC7NECV4L/p1709812877445629
I think this was a minor version bump and testing the console error on sending a message. I feel like $250 is a fair bounty.
Other than previous occurrences, if there is other reason for the bounty, we would be happy to evaluate and double it.
anmurali commentedon Mar 21, 2024
https://www.upwork.com/nx/wm/offer/101507041
@mkhutornyi can you accept and then DM me on slack so I can pay it. Gonna close the issue now.