[ON HOLD] [MEDIUM] [Splits] [$250] Split bill - Split amount is lost when adding receipt and splitting bill

@youssef-lr

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v1.4.45-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): natnael.expensify+3@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal Team

Action Performed:

Click on 'FAB' > Request money > enter amount
Select a user > Add receipt > return to where you can select a user
Click on 'Split' button
Click on 'Add to split' > click on 'Split'

Expected Result:

Entered amount shouldn't be lost, and request shouldn't change to scan request

Actual Result:

Entered amount is lost and request is changed to a scan request

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6396788_1709201886587.Screen_Recording_2024-02-29_at_10.49.14_in_the_morning.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e554328af9becb46
Upwork Job ID: 1763525709189742592
Last Price Increase: 2024-08-08
Automatic offers:

shubham1206agra | Reviewer | 0
rojiphil | Contributor | 0

Issue Owner

Current Issue Owner: @youssef-lr

Issue Owner

Current Issue Owner: @youssef-lr

@isabelastisser

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@grgia

Triggered auto assignment to @grgia (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@grgia

@grgia I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

I believe this is happening with manual requests too

Proposal

Please re-state the problem that we are trying to solve in this issue.

When Split bill is used with a receipt, the split amount is lost in the split bill details page.

What is the root cause of that problem?

Here, when we split the bill with a receipt, it was thought to be done via the scan tab where we do not enter the amount. In such a case, the flow starts with a split bill request and is completed later. However, as done in this issue, it is also possible to split the bill via Manual request with an added receipt. Currently, this goes through the default startSplit flow. This is the root cause.

I do not think this is a regression.

What changes do you think we should make in order to solve the problem?

We can support split bill request for manual request type with receipt by making use of the splitBill here and splitBillAndOpenReport here.

First, we need to avoid going through the startSplitBill flow by additionally checking for a valid amount like this here
```
     if (iouType === CONST.IOU.TYPE.SPLIT && receiptFile && transaction.amount === 0) {
```
Now, the flow with either go through splitBill here or splitBillAndOpenReport here. Here, let us pass the receiptFile into splitBill and splitBillAndOpenReport as it is done here.
Inside the createSplitsAndOnyxData here, generate the receiptObject like it is done here and add this to the transaction here and iou report action here. Further, we need to add the receipt to one-to-one iou report actions and transactions too here. Also, failure data can consider receipt error using getReceiptError like here

However, this would also need BE support as SplitBill API need to send back receipt in response.

What alternative solutions did you explore? (Optional)

Alternatively, if we want to do this via startSplitBill flow, we can include amount in the flow. Here, I think even BE needs to ensure that transaction contains the amount. Happy to explore more on this if we want to go through this approach.

FYI, this is likely fixed by this revert. Will have QA re-test once it is CP'd.

@rojiphil

woah... that's a lotta comments.

If a contributor was hired and PR created that was reviewed by the C+, both are due 100%.
@rojiphil , @shubham1206agra can you confirm the above? If so, @kadiealexander , can you plz pay? Thx

@mallenexpensify

@mallenexpensify Yes, that's correct

@mallenexpensify

Thanks @mallenexpensify for reopening.

@kadiealexander As mentioned here, 100% compensation is due here for me as contributor as the PR was worked on and paused due to BE dependency. Thanks.

@kadiealexander

@kadiealexander Gentle bump on helping with payment summary here. Thanks

@youssef-lr

@youssef-lr Huh... This is 4 days overdue. Who can take care of this?

Not overdue.

@rojiphil

Payment Summary

Contributor: @rojiphil due $250 via NewDot
Contributor+: @shubham1206agra due $250 via NewDot

@rojiphil

Approved $250 to @rojiphil

@shubham1206agra

$250 approved for @shubham1206agra

Navigation Menu

Repository navigation

[ON HOLD] [MEDIUM] [Splits] [$250] Split bill - Split amount is lost when adding receipt and splitting bill #37491

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

192 remaining items

Payment Summary

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[ON HOLD] [MEDIUM] [Splits] [$250] Split bill - Split amount is lost when adding receipt and splitting bill #37491

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Feb 29, 2024

github-actions commented on Feb 29, 2024

melvin-bot commented on Feb 29, 2024

izarutskaya commented on Feb 29, 2024

grgia commented on Feb 29, 2024

rojiphil commented on Feb 29, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

puneetlath commented on Feb 29, 2024

192 remaining items

mallenexpensify commented on Jan 14, 2026

shubham1206agra commented on Jan 14, 2026

rojiphil commented on Jan 14, 2026

rojiphil commented on Jan 19, 2026

melvin-bot commented on Jan 19, 2026

youssef-lr commented on Jan 21, 2026

kadiealexander commented on Jan 28, 2026

Payment Summary

quinthar commented on Mar 5, 2026

garrettmknight commented on Apr 2, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions