Skip to content

Group Split - Error shows for Merchant and not Amount, while Merchant leads to error page #37523

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.45-1

Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to group chat.
  3. Click + > Split bill > Scan.
  4. Create a scan split bill.
  5. Click on the split preview.
  6. Click Split.
  7. Note that it shows error for Merchant and not amount.
  8. Click Merchant.

Expected Result:

In Step 6, it will show error for Amount only.
In Step 7, Merchant editor page will open without issue.

Actual Result:

In Step 6, it shows error for Merchant and not Amount.
In Step 7, Merchant leads to not here page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6397136_1709217415986.bandicam_2024-02-29_18-14-02-957.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 29, 2024
  2. melvin-bot commented on Feb 29, 2024

    @melvin-bot

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. github-actions commented on Feb 29, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot commented on Feb 29, 2024

    @melvin-bot

    Triggered auto assignment to @deetergp (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. m-natarajan commented on Feb 29, 2024

    @m-natarajan
    Author

    We think that this bug might be related to #vip-split-p2p-chat-groups
    cc @arielgreen

  6. m-natarajan commented on Feb 29, 2024

    @m-natarajan
    Author

    @deetergp FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  7. hoangzinh commented on Feb 29, 2024

    @hoangzinh
    Contributor

    I found this bug and reported here #37515 (comment). @kubabutkiewicz I think we can fix this issue in your current PR #37515

  8. puneetlath commented on Feb 29, 2024

    @puneetlath
    Contributor

    Looks like the revert fixed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions