[HOLD for payment 2024-05-09] [$500] Hold Request - "Hold" banner is aligned to the top when there is scan request message

@isabelastisser

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.45-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Go to staging.new.expensify.com
Go to 1:1 DM
Create a scan request
Go to request details page
Click 3-dot menu > Hold request
Add a reason and save it

Expected Result:

The "Hold" banner will be aligned in the middle of the given space

Actual Result:

The "Hold" banner is aligned to the top of the given space when there is scan request message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6397350_1709227408773.20240229_234646.mp4

Bug6397350_1709227408781!Screenshot_2024-03-01_at_01 12 12

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01dd5d1b7c81a77704
Upwork Job ID: 1763306586849918976
Last Price Increase: 2024-03-07
Automatic offers:

neonbhai | Contributor | 0

Issue Owner

Current Issue Owner: @isabelastisser

@isabelastisser

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@RachCHopkins

We think that this bug might be related to #wave7
CC @RachCHopkins

@isabelastisser

@isabelastisser I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Hold" banner is aligned to the top when there is scan request message

What is the root cause of that problem?

We only have bottom padding for hold banner as per here. It only works when there's only it and no other banners (money request status bar) above.

What changes do you think we should make in order to solve the problem?

Add a prop shouldShowPaddingTop to HoldBanner. This check will be true when there's any other status bar above (e.g., MoneyRequestHeaderStatusBar).

<HoldBanner shouldShowPaddingTop={isPending || isScanning} />

In that case, we use styles.pv3 for the HoldBanner. Otherwise, only use pb3.

What alternative solutions did you explore? (Optional)

NA

@lanitochka17

@lanitochka17 I agree that this can barely be noticed. I raised it for discussion in Slack.

Job added to Upwork: https://www.upwork.com/jobs/~01dd5d1b7c81a77704

@Santhosh-Sellavel

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

@Santhosh-Sellavel

Bump @Santhosh-Sellavel

@Santhosh-Sellavel

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR: [WAVE 7] Hold Requests: Individual Money Request Page, Reason Interstitial, Banner #33897 (comment)
[@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: [WAVE 7] Hold Requests: Individual Money Request Page, Reason Interstitial, Banner #33897 (comment)
[@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Alignment issue should have been caught while testing.
[@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
Mainly this bug its a minor UI Polish. Also about the bug that Hold option shown while report in scanning state, now its been fixed, it's not the case user might run into easily. cc: @francoisl your thoughts if you disagree
[@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/A

@francoisl

@francoisl, @dragnoir, @isabelastisser, @neonbhai, @Santhosh-Sellavel Whoops! This issue is 2 days overdue. Let's get this updated quick!

@isabelastisser

Works for me. @isabelastisser feel free to process the payments and close the issue. Thanks!

@isabelastisser

Noting that the PR was reviewed by me here but seems like the automation didn't mention it. Please take a look 🙇

cc: @isabelastisser

@isabelastisser

@isabelastisser pls consider this when payment #37536 (comment)

Thank you

@shawnborton

Based on @shawnborton's comment here, I'm increasing the payment to @dragnoir to $750.

Payments summary:

@dragnoir requires payment $750 (manual offer https://www.upwork.com/nx/wm/offer/102358820)
@neonbhai requires payment automatic offer (Contributor) $750
@Santhosh-Sellavel requires payment through NewDot Manual Requests $500 PENDING

All set!

@isabelastisser

@isabelastisser offer accepted. Thank you

@isabelastisser

@isabelastisser hi, the original job was split with me and @dragnoir. As noted here #37536 (comment)

I also ended up reviewing one of the linked PRs, so the payout would be $250 + $500 for me! Please take a look 🙇

Requested on ND

@Santhosh-Sellavel

$500 approved for @Santhosh-Sellavel

Navigation Menu

Repository navigation

[HOLD for payment 2024-05-09] [$500] Hold Request - "Hold" banner is aligned to the top when there is scan request message #37536

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

86 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-05-09] [$500] Hold Request - "Hold" banner is aligned to the top when there is scan request message #37536

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Feb 29, 2024

lanitochka17 commented on Feb 29, 2024

lanitochka17 commented on Feb 29, 2024

gijoe0295 commented on Feb 29, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

isabelastisser commented on Feb 29, 2024

melvin-bot commented on Feb 29, 2024

melvin-bot commented on Feb 29, 2024

86 remaining items

isabelastisser commented on May 16, 2024

Santhosh-Sellavel commented on May 16, 2024

melvin-bot commented on May 16, 2024

francoisl commented on May 16, 2024

neonbhai commented on May 16, 2024

dragnoir commented on May 17, 2024

isabelastisser commented on May 17, 2024

isabelastisser commented on May 17, 2024

dragnoir commented on May 17, 2024

neonbhai commented on May 17, 2024

Santhosh-Sellavel commented on May 22, 2024

JmillsExpensify commented on May 31, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions