Skip to content

[$500] [HOLD for payment 2024-03-19] Do not show "member not found" when loading member list #37605

Closed

Description

@luacmartins

Coming from this comment, we should not show "member not found" while loading the member list

cc @burczu

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d5126ce1290525b2
  • Upwork Job ID: 1770042366576177152
  • Last Price Increase: 2024-03-19

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 1, 2024
  2. self-assigned this
    on Mar 1, 2024
  3. melvin-bot commented on Mar 1, 2024

    @melvin-bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. aimane-chnaif commented on Mar 1, 2024

    @aimane-chnaif
    Contributor

    Happy to review this as C+

  5. rayane-d commented on Mar 1, 2024

    @rayane-d
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    we are showing "member not found" while loading the member list.

    What is the root cause of that problem?

    Here:

    const getHeaderMessage = () => {
    if (isOfflineAndNoMemberDataAvailable) {
    return translate('workspace.common.mustBeOnlineToViewMembers');
    }
    return !data.length ? translate('workspace.common.memberNotFound') : '';
    };

    when data is empty we show the "member not found" message, but we should not show it when members are still loading

    What changes do you think we should make in order to solve the problem?

    we should use the same condition used here:

    showLoadingPlaceholder={!isOfflineAndNoMemberDataAvailable && (!OptionsListUtils.isPersonalDetailsReady(personalDetails) || isEmptyObject(policyMembers))}

    in getHeaderMessage function, like this:

        const getHeaderMessage = () => {
            if (isOfflineAndNoMemberDataAvailable) {
                return translate('workspace.common.mustBeOnlineToViewMembers');
            }
            return (!data.length && (!OptionsListUtils.isPersonalDetailsReady(personalDetails) || isEmptyObject(policyMembers))) ? translate('workspace.common.memberNotFound') : '';
        };
  6. aimane-chnaif commented on Mar 1, 2024

    @aimane-chnaif
    Contributor

    I am not sure this will be be external.
    @burczu may take this.

  7. burczu commented on Mar 1, 2024

    @burczu
    Contributor

    Hey I'm Bartek from Callstack - could you please assign this issue to me?

  8. 17 remaining items

  9. melvin-bot commented on Mar 12, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.50-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-03-19. 🎊

    For reference, here are some details about the assignees on this issue:

    • @burczu does not require payment (Contractor)
    • @aimane-chnaif requires payment (Needs manual offer from BZ)
  10. melvin-bot commented on Mar 12, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
    • [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@aimane-chnaif] Determine if we should create a regression test for this bug.
    • [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  11. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 19, 2024
  12. melvin-bot commented on Mar 19, 2024

    @melvin-bot
  13. changed the title [-][HOLD for payment 2024-03-19] Do not show "member not found" when loading member list[/-] [+][$500] [HOLD for payment 2024-03-19] Do not show "member not found" when loading member list[/+] on Mar 19, 2024
  14. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 19, 2024
  15. removed
    ExternalAdded to denote the issue can be worked on by a contributor
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 19, 2024
  16. melvin-bot commented on Mar 19, 2024

    @melvin-bot

    Current assignee @aimane-chnaif is eligible for the External assigner, not assigning anyone new.

  17. zanyrenney commented on Mar 19, 2024

    @zanyrenney
    Contributor

    @aimane-chnaif invited you to job on UW - https://www.upwork.com/jobs/~01d5126ce1290525b2 pls accept for payout.

  18. zanyrenney commented on Mar 19, 2024

    @zanyrenney
    Contributor

    accepted proposal.

  19. zanyrenney commented on Mar 19, 2024

    @zanyrenney
    Contributor

    payment summary:
    @burczu does not require payment (Contractor)
    @aimane-chnaif requires payment (Needs manual offer from BZ) - paid $500 on Upwork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions