You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] [HOLD for payment 2024-03-19] Do not show "member not found" when loading member list #37605
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.50-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
[@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@aimane-chnaif] Determine if we should create a regression test for this bug.
[@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2024-03-19] Do not show "member not found" when loading member list[/-][+][$500] [HOLD for payment 2024-03-19] Do not show "member not found" when loading member list[/+]on Mar 19, 2024
Activity
melvin-bot commentedon Mar 1, 2024
Triggered auto assignment to @zanyrenney (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.aimane-chnaif commentedon Mar 1, 2024
Happy to review this as C+
rayane-d commentedon Mar 1, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
we are showing "member not found" while loading the member list.
What is the root cause of that problem?
Here:
App/src/pages/workspace/WorkspaceMembersPage.tsx
Lines 352 to 357 in 85dc2f6
when data is empty we show the "member not found" message, but we should not show it when members are still loading
What changes do you think we should make in order to solve the problem?
we should use the same condition used here:
App/src/pages/workspace/WorkspaceMembersPage.tsx
Line 461 in 85dc2f6
in
getHeaderMessagefunction, like this:aimane-chnaif commentedon Mar 1, 2024
I am not sure this will be be external.
@burczu may take this.
burczu commentedon Mar 1, 2024
Hey I'm Bartek from Callstack - could you please assign this issue to me?
17 remaining items
melvin-bot commentedon Mar 12, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.50-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-03-19. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 12, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Mar 19, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01d5126ce1290525b2
[-][HOLD for payment 2024-03-19] Do not show "member not found" when loading member list[/-][+][$500] [HOLD for payment 2024-03-19] Do not show "member not found" when loading member list[/+]melvin-bot commentedon Mar 19, 2024
Current assignee @aimane-chnaif is eligible for the External assigner, not assigning anyone new.
zanyrenney commentedon Mar 19, 2024
@aimane-chnaif invited you to job on UW - https://www.upwork.com/jobs/~01d5126ce1290525b2 pls accept for payout.
zanyrenney commentedon Mar 19, 2024
accepted proposal.
zanyrenney commentedon Mar 19, 2024
payment summary:
@burczu does not require payment (Contractor)
@aimane-chnaif requires payment (Needs manual offer from BZ) - paid $500 on Upwork.