[HOLD for payment 2024-06-05] [$500] Fix scrollable elements in Policy pages

@MitchExpensify

Coming from this comment, all elements but the page header should scroll on policy pages, e.g. members, categories, tags. etc

chrome.mov

cc @Expensify/design

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010982d541dff55b4c
Upwork Job ID: 1765759901307744256
Last Price Increase: 2024-03-07
Automatic offers:

akinwale | Contributor | 0

Issue Owner

Current Issue Owner: @MitchExpensify

@MitchExpensify

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

So the whole page should scroll just like it does everywhere else, got it. I'll make this external tomorrow

Proposal

Please re-state the problem that we are trying to solve in this issue.

Only the list element can be scrolled on policy page

What is the root cause of that problem?

The SectionList is rendered as FlatList so it can be scrolled but we don't wrap WorkspaceMembersPage into a ScrollView and then it cannot be scrolled

App/src/pages/workspace/WorkspaceMembersPage.tsx

Line 520 in ffa731a

What changes do you think we should make in order to solve the problem?

We can wrap all elements after the header like subtitle, ... or only SelectionList into a scroll view instead of a view and do the same way for other pages like category, tags, .... on policy pages

<ScrollView>
....
</ScrollView>

App/src/pages/workspace/WorkspaceMembersPage.tsx

Line 520 in ffa731a

What alternative solutions did you explore? (Optional)

NA

@MitchExpensify

Current assignee @MitchExpensify is eligible for the Bug assigner, not assigning anyone new.

Job added to Upwork: https://www.upwork.com/jobs/~010982d541dff55b4c

@akinwale

[@akinwale] The PR that introduced the bug has been identified. Link to the PR:

[@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

[@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

This is a new feature.

[@akinwale] Determine if we should create a regression test for this bug.

[@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps
Precondition: Members, Distance rates, Categories, Tags and Taxes screens should have multiple records to the point where the records can be scrolled

Launch the Expensify app
Select a Collect or Control workspace from the workspaces page

Devices with width greater than 800px

Open any one of the Members, Distance rates, Categories, Tags or Taxes screens
Verify that the options are scrollable on each page, and the options scroll as expected

Devices with width less than 800px

Open any one of the Members, Distance rates, Categories, Tags or Taxes screens
Verify that the options list scrolls properly on each screen
Verify that the page description at the top and the thead scrolls while the buttons are fixed.

Do we agree 👍 or 👎?

@akinwale

Reminder set to pay, @akinwale thoughts on the BZ steps?

@MitchExpensify Checklist completed.

@MitchExpensify

@MitchExpensify bump for payment. Thanks.

@akinwale

Paid and contract ended, thanks @akinwale !

@MitchExpensify

@MitchExpensify, I haven't been paid yet, automatic offer wasn't sent to me at the time of assignment.

Oh ok, I'm actually unsure what to do in that case. Are you expecting to be paid via Upwork or NewDot just to be sure?

@MitchExpensify

@MitchExpensify, through Upwork :)

Offer sent here Fix scrollable elements in Policy pages #37782

@MitchExpensify

@MitchExpensify, accepted.

@Krishna2323

Paid and contract ended! Thanks for your patience @Krishna2323

Navigation Menu

Repository navigation

[HOLD for payment 2024-06-05] [$500] Fix scrollable elements in Policy pages #37782

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

48 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-06-05] [$500] Fix scrollable elements in Policy pages #37782

Description

Activity

melvin-bot commented on Mar 5, 2024

MitchExpensify commented on Mar 7, 2024

dukenv0307 commented on Mar 7, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Mar 7, 2024

melvin-bot commented on Mar 7, 2024

48 remaining items

akinwale commented on Jun 5, 2024

akinwale commented on Jun 5, 2024

akinwale commented on Jun 7, 2024

MitchExpensify commented on Jun 8, 2024

Krishna2323 commented on Jun 8, 2024

MitchExpensify commented on Jun 11, 2024

Krishna2323 commented on Jun 11, 2024

MitchExpensify commented on Jun 11, 2024

Krishna2323 commented on Jun 11, 2024

MitchExpensify commented on Jun 11, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions