LHN can be scrolled horizontally while closed.

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

LHN can be scroll horizontally and a scrollbar is present only when no chat is active.

Action Performed:

Open E.cash Mobile web.
Open any chat.
Close the chat, go back to the home page or LHN.
Try to scroll the page horizontally.

Expected Result:

Describe what you think should've happened
No scrollbar should be present and We should not be able to scroll the page and see the inactive chat page.

Actual Result:

Users can scroll the page and see the inactive chat in the background which is non-interactable.

Workaround:

Just a UI glitch.

Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web ✔️

Version Number: Latest
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

1624916807068.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

@stephanieelliott

Triggered auto assignment to @stephanieelliott (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

Proposal

We need to disable the horizontal overflow on the Main Drawer Container. Using overflow-x:hidden to fix this issue.

I think this will fix #3768 as well.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@marcaaron

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Oh, jk this doesn't need to be a deploy blocker because it exists on production too.

yeah as overflow is in Y-axis so overflowX will not have any effect. But I am yet to test the issue but before I need to reproduce it. Will share an update today on that.

@MitchExpensify

Hey, @MitchExpensify @roryabraham. I reproduced #3768 and tested my solution over it and guess what I was correct. we have to prevent overflow on the Drawer screen to fix both of the issues.

To fix both issues:

We will add cardStyle: {overflow: hidden} option to the Drawer route here https://github.com/Expensify/Expensify.cash/blob/c5707430dff9ecfb631012bb0ba25357c7f367e5/src/libs/Navigation/AppNavigator/AuthScreens.js#L236.
So this route will change to this code.

 <RootStack.Screen
                    name={SCREENS.HOME}
                    options={{
                        headerShown: false,
                        title: 'Expensify.cash',
                        cardStyle: {
 // Prevent scrolling and Overflow widgets
                            overflow: 'hidden',
                        },
                    }}
                    component={MainDrawerNavigator}
                />

fix-scroll.mp4

Waiting for the next instructions. Let's get this fix pushed which crosses off two issues from the board. Thanks.

@MitchExpensify

@MitchExpensify Since you're conveniently managing both this issue and #3768, let's hire @parasharrajat for the one Upwork Job, then assuming his PR fixes both issues (like it looks like it will), let's pay him:

For that upwork job
A bonus for this issue (since AFAICT there's no Upwork job here yet)
Plus the additional bounty for opening for this issue and also providing the solution.

@stephanieelliott

Oops, sorry I got confused here @stephanieelliott and thought @MitchExpensify was managing this issue. If the above sounds like a good plan I would suggest just reassigning this to @MitchExpensify to manage after the PR is merged.

@MitchExpensify

Since there is a proposal here, we actually need to pay these jobs out separately to keep this clean in terms of Upwork ToS. So rather than paying out via a bonus, let's post this a separate job and hire Rajat to it directly if the PR solves both issues.

Tossing back to @MitchExpensify to manage, but feel free to reassign to me if the plan changes!

Sounds good! So I will reopen that Upwork job (done!), accept Rajat's proposal, and pay (with bonus) 7 days after merge assuming all goes smoothly. .

@Beamanator

Triggered auto assignment to @Beamanator (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

PR is up #3856 already. It's a quick one and can be merged. Thanks.

@parasharrajat

Sorry for the delay on bonus and bounty payment @parasharrajat while I wass ooo last week. That has now been made in Upwork!

Navigation Menu

Repository navigation

LHN can be scrolled horizontally while closed. #3781

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

Proposal

5 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

LHN can be scrolled horizontally while closed. #3781

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

Activity

MelvinBot commented on Jun 28, 2021

parasharrajat commented on Jun 28, 2021

Proposal

OSBotify commented on Jun 29, 2021

MelvinBot commented on Jun 29, 2021

roryabraham commented on Jun 29, 2021

5 remaining items

parasharrajat commented on Jun 29, 2021

parasharrajat commented on Jul 1, 2021

parasharrajat commented on Jul 1, 2021

roryabraham commented on Jul 1, 2021

roryabraham commented on Jul 1, 2021

stephanieelliott commented on Jul 1, 2021

MitchExpensify commented on Jul 1, 2021

MelvinBot commented on Jul 1, 2021

parasharrajat commented on Jul 1, 2021

MitchExpensify commented on Jul 19, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions