[HOLD for payment 2024-04-03] [$500] Collect approver - "Waiting for you to pay these expenses" is briefly displayed for approver

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.48-8
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Precondition:

The Collect workspace has admin, employee and a non-reimburser approver.
Workspace has direct reimbursement.

[Employee] Go to workspace chat.
{Employee] Create a manual request and submit it.
[Approver] Go to workspace chat with employee.
[Approver] Click on the expense preview to go to expense report.
[Approver] Click Approve.

Expected Result:

The Next step message should only show "Waiting for your admin to pay these expenses".

Actual Result:

The Next step message briefly shows "Waiting for you to pay these expenses" after approving the report, which is a message meant for reimburser.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6404828_1709778120135.20240307_101241.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0126815d05bb2e844f
Upwork Job ID: 1765765668601966592
Last Price Increase: 2024-03-07

@mallenexpensify

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@mallenexpensify

@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@greg-schroeder

We think that this bug might be related to #wave6-collect-submitters
cc @greg-schroeder

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Next step message briefly shows "Waiting for you to pay these expenses" after approving the report, which is a message meant for reimburser.

What is the root cause of that problem?

When we built the next step for the approved case we returned the wrong next step message for the case the approver isn't the owner of the request

App/src/libs/NextStepUtils.ts

Line 278 in ffa731a

if (!isOwner) {

What changes do you think we should make in order to solve the problem?

In this case, we should return your admin here instead of you

App/src/libs/NextStepUtils.ts

Line 278 in ffa731a

if (!isOwner) {

OPTIONAL: We can add a check if the approver is an admin we still can return you otherwise return your admin

What alternative solutions did you explore? (Optional)

NA

@m-natarajan

@m-natarajan @mallenexpensify any idea how to create a non-reimburser approver account?

Job added to Upwork: https://www.upwork.com/jobs/~0126815d05bb2e844f

@fedirjh

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

@fedirjh

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
[@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@fedirjh] Determine if we should create a regression test for this bug.
[@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@mallenexpensify

Can you please initiate the payment for this @mallenexpensify this is past regression period , thanks

@fedirjh

@GandalfGwaihir @fedirjh , can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~0126815d05bb2e844f

@GandalfGwaihir , I sent you a new offer since you said you had trouble accepting the other.
Thx

@mallenexpensify

@mallenexpensify Thank you. Accepted.

BugZero Checklist:

Link to the PR: [CP Staging] Update nextStep on payment cancellation #36798
Link to comment: Author is aware of the bug.
Link to discussion: N/A
Determine if we should create a regression test for this bug:

Regression Test Proposal

Precondition:
    - The Collect workspace has admin, employee and a non-reimburser approver.
    - Workspace has direct reimbursement.

1. [Employee] Go to workspace chat.
2. [Employee] Create a manual request and submit it.
3. [Approver] Go to workspace chat with employee.
4. [Approver] Click on the expense preview to go to expense report.
5. [Approver] Click Approve.
6. Verify the Next step message is "Waiting for your admin to pay these expenses".

Do we agree 👍 or 👎

@mallenexpensify

@GandalfGwaihir , I sent you a new offer since you said you had trouble accepting the other.
Thx

@mallenexpensify , accepted the new offer thanks a lot :)

@fedirjh

Contributor: @GandalfGwaihir paid $500 via Upwork
Contributor+: @fedirjh paid $500 via Upwork.

@fedirjh can you please accept the job and reply here once you have? It still shows the offer hasn't been accepted.
https://www.upwork.com/jobs/~0126815d05bb2e844f

Testrail GH https://github.com/Expensify/Expensify/issues/385885

@mallenexpensify

@mallenexpensify There was an error with the automatic offer, #37866 (comment).

I already submitted a new proposal here

@fedirjh

I think I just hired you @fedirjh and you need to confirm so I can pay, can you look https://www.upwork.com/jobs/~0126815d05bb2e844f

@mallenexpensify

@mallenexpensify Thank you. Accepted.

@fedirjh

Paid @fedirjh , updated the payment confirmation above. Thx

Navigation Menu

Repository navigation

[HOLD for payment 2024-04-03] [$500] Collect approver - "Waiting for you to pay these expenses" is briefly displayed for approver #37866

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

30 remaining items

BugZero Checklist:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-04-03] [$500] Collect approver - "Waiting for you to pay these expenses" is briefly displayed for approver #37866

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Mar 7, 2024

m-natarajan commented on Mar 7, 2024

m-natarajan commented on Mar 7, 2024

dukenv0307 commented on Mar 7, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

dragnoir commented on Mar 7, 2024

melvin-bot commented on Mar 7, 2024

melvin-bot commented on Mar 7, 2024

30 remaining items

melvin-bot commented on Mar 27, 2024

allgandalf commented on Apr 5, 2024

mallenexpensify commented on Apr 6, 2024

fedirjh commented on Apr 6, 2024

fedirjh commented on Apr 6, 2024

BugZero Checklist:

allgandalf commented on Apr 7, 2024

mallenexpensify commented on Apr 7, 2024

fedirjh commented on Apr 7, 2024

mallenexpensify commented on Apr 7, 2024

fedirjh commented on Apr 7, 2024

mallenexpensify commented on Apr 7, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions