Repository navigation
[HOLD for payment 2024-03-20] Tag - Newly added tags aren't displayed under the "Tags" section in workspace settings #37873
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.48-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+alm1018@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal Team
Action Performed:
Precondition:
User is an admin of Collect workspace with no previously added tags (you should add new tags before steps reproduction )
- Navigate to staging.new.expensify.com
- Go to Workspace settings > Collect workspace
- Select the "Tags" tab
- Add some tags via classic app
- Refresh the page to see the newly added tags
Expected Result:
Newly added tags should be displayed under the "Tags" section in workspace settings.
Actual Result:
Newly added tags aren't displayed under the "Tags" section in workspace settings.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
melvin-bot commentedon Mar 7, 2024
Triggered auto assignment to @greg-schroeder (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.github-actions commentedon Mar 7, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Mar 7, 2024
Triggered auto assignment to @MonilBhavsar (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.izarutskaya commentedon Mar 7, 2024
@MonilBhavsar I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
We think that this bug might be related to #wave8-collect-admins
CC @zanyrenney
MonilBhavsar commentedon Mar 7, 2024
@luacmartins @waterim @Abdallah-Ahmed-moh looks like it is coming from this PR #37621
Given that this is WIP under simplified collect, I think this is not a not a blocker. Let me know what do you think
21 remaining items
[-]Tag - Newly added tags aren't displayed under the "Tags" section in workspace settings[/-][+][HOLD for payment 2024-03-20] Tag - Newly added tags aren't displayed under the "Tags" section in workspace settings[/+]melvin-bot commentedon Mar 13, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-03-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 13, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Mar 20, 2024
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
greg-schroeder commentedon Mar 25, 2024
Apologies, I was OOO last week. Taking a look at this now!
greg-schroeder commentedon Mar 25, 2024
Closing per #37873 (comment)