Repository navigation
[HOLD for payment 2024-05-08] [Simplified Collect][CLEAN UP][LOW] Standardize on Workspace wrapper #37898
Description
Problem
Coming from here, we have a few wrappers we use in Workspace pages, i.e. WorkspacePageWithSections, AdminPolicyAccessOrNotFoundWrapper and PaidPolicyAccessOrNotFoundWrapper. We should standardize on using a single one for all our pages.
Those wrappers also break the not-found views.
Going to e.g. https://staging.new.expensify.com/workspace/dssaddssdaads/categories` we see duplicated not found (that's what is the scope of the other issue) and after pressing the back button we see another ones...
Why is this important
DRYs code and makes it more maintainable
Solution
Investigate how to combine them and update all usages.
cc @kosmydel
Issue Owner
Current Issue Owner: @JmillsExpensifyReacted by Jakub Kosmydel
Activity
melvin-bot commentedon Mar 7, 2024
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Mar 12, 2024
@JmillsExpensify, @luacmartins Eep! 4 days overdue now. Issues have feelings too...
JmillsExpensify commentedon Mar 13, 2024
Added a weekly here since this is low and in the polish bucket.
luacmartins commentedon Mar 13, 2024
Polish item
kosmydel commentedon Mar 21, 2024
A new wrapper
FeatureEnabledAccessOrNotFoundWrapper.tsxemerged in this PR.I've consulted it internally, and someone from SWM will take care of this issue.
36 remaining items
melvin-bot commentedon May 8, 2024
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
melvin-bot commentedon May 13, 2024
@JmillsExpensify, @luacmartins, @BrtqKr Huh... This is 4 days overdue. Who can take care of this?
BrtqKr commentedon May 14, 2024
It was merged some time ago #40598, not sure why Melvin is still mentioning us. Would you mind closing this issue, or is there anything left to do?
luacmartins commentedon May 14, 2024
It seems like we need to payout C+ @ahmedGaber93 for the PR review.
melvin-bot commentedon May 17, 2024
@JmillsExpensify, @luacmartins, @ahmedGaber93, @BrtqKr Whoops! This issue is 2 days overdue. Let's get this updated quick!
JmillsExpensify commentedon May 19, 2024
Payment summary: @ahmedGaber93 $500 for pr review and testing.
JmillsExpensify commentedon May 19, 2024
Offer sent via Upwork
JmillsExpensify commentedon May 19, 2024
Offer paid out, so closing out this issue.