Skip to content

[HOLD for payment July 20] Markdown - Copied text (with markdown) does not show the formatting when pasted in e.cash #3790

Closed

Description

@isagoico

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Upwork job: https://www.upwork.com/jobs/~01784929033238eacd


Action Performed:

  1. Copy the following text:

Bold text
italic text
Strikethrough text

  • Bullet points test

  • Another Bullet point

    Indents test

  1. Paste the text in e.cash

Expected Result:

Formatting should be displayed in e.cash.

Actual Result:

Text is pasted without any formatting. Only line breaks are displayed.

Workaround:

User has to edit the text in e.cash compose box and add the markdown manually.

Platform:

Where is this issue occurring?

Web ✔️
iOS
Android
Desktop App
Mobile Web

Version Number: 1.0.74-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

image

Expensify/Expensify Issue URL:

View all open jobs on Upwork


From @mallenexpensify https://expensify.slack.com/archives/C01GTK53T8Q/p1617291564288600

When copying text (gmail draft in this example) and pasting into e.cash, formatting is being stripped. I can create an issue for it, wondering if we should attempt to fix parts of it first, like line breaks, then markdown in a separate issue? Thoughts/ideas?

Activity

  1. MelvinBot commented on Jun 29, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. mallenexpensify commented on Jun 30, 2021

    @mallenexpensify
    Contributor

    @tylerkaraszewski this can be worked on by a contributor, right? If so, can you add the External label, thanks

  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 30, 2021
  4. MelvinBot commented on Jun 30, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @Jag96 (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  5. tylerkaraszewski commented on Jun 30, 2021

    @tylerkaraszewski
    Contributor

    Seems straightforward for an external contributor to work on.

  6. parasharrajat commented on Jun 30, 2021

    @parasharrajat
    Member

    It is not straightforward but looks like so.

    1. We need to convert the copied HTML to MD first. and then show the MD in composer.
    2. We do not support lists. So we have to decide what can be done about that.
  7. rdjuric commented on Jun 30, 2021

    @rdjuric
    Contributor

    Feels like this one should hold until #3229?

  8. mallenexpensify commented on Jun 30, 2021

    @mallenexpensify
    Contributor

    Reassigning @Jag96

  9. 20 remaining items

  10. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 9, 2021
  11. parasharrajat commented on Jul 9, 2021

    @parasharrajat
    Member

    @Jag96 Thanks for the invite. But Changes to HTML->MD conversion should be separate issues and looking at the complexity, possibly multiple for the different tags listed here #3047.

  12. Jag96 commented on Jul 9, 2021

    @Jag96
    Contributor

    Ok, how about we split this up into 2 issues:

    1. Implement one of the conversions in [Tracking Issue] Implement HTML -> Markdown conversions in Expensimark #3047 (maybe italics?) to help confirm this will work
    2. Update e.cash to ensure the HTML copy works, and that it can be converted to MD for the currently existing tags (including the one we add in the step above)

    Then the rest of the HTML->MD conversions can happen in #3047. How does that sound @parasharrajat?

  13. parasharrajat commented on Jul 9, 2021

    @parasharrajat
    Member

    @Jag96 Sounds good.

  14. Jag96 commented on Jul 10, 2021

    @Jag96
    Contributor

    Created another issue here and invited @parasharrajat to the Upwork job. Used the italics conversion for the title, but feel free to choose any of the items from the tracking issue.

  15. Jag96 commented on Jul 14, 2021

    @Jag96
    Contributor

    Reopening to keep track of payment

  16. changed the title [-]Markdown - Copied text (with markdown) does not show the formatting when pasted in e.cash[/-] [+][HOLD for payment July 20] Markdown - Copied text (with markdown) does not show the formatting when pasted in e.cash[/+] on Jul 14, 2021
  17. reopened this on Jul 14, 2021
  18. parasharrajat commented on Jul 21, 2021

    @parasharrajat
    Member

    @Jag96 any update here? Thanks

  19. Jag96 commented on Jul 21, 2021

    @Jag96
    Contributor

    Paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions