[HOLD for payment 2024-04-05] [$125] Workspace - Categories load without loading spinner

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Found when validating PR : #37457

Version Number: v1.4.48-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+ihchat4_2902_c@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Pre-requisite: an admin account with a policyExpenseChat enabled Collect policy and another workspace.

Open the app
Login with admin account with Collect policy
Navigate to Workspace > Settings and select the collect policy.
Select the Categories page
Verify that you see the loading spinner

Expected Result:

Categories load with loading spinner

Actual Result:

Categories load without loading spinner

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

2024-03-07.16.27.56.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01197fc8d66a9362f0
Upwork Job ID: 1770919042911531008
Last Price Increase: 2024-03-21
Automatic offers:

DylanDylann | Reviewer | 0
GandalfGwaihir | Contributor | 0

@alexpensify

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@alexpensify

@alexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@zanyrenney

We think that this bug might be related to #wave8-collect-admins
CC @zanyrenney

Proposal

Please re-state the problem that we are trying to solve in this issue.

Categories load without loading spinner

What is the root cause of that problem?

We have loading spinner logic on the page, but we only check if the policyCategories are undefined, but these can be null, before fetching. Since isLoading isn't true when it is null. No loading spinner is shown

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Lines 172 to 178 in c270b5e

    
           {isLoading && ( 
        
               <ActivityIndicator 
        
                   size={CONST.ACTIVITY_INDICATOR_SIZE.LARGE} 
        
                   style={[styles.flex1]} 
        
                   color={theme.spinner} 
        
               /> 
        
           )}

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Line 128 in c270b5e

const isLoading = !isOffline && policyCategories === undefined;

What changes do you think we should make in order to solve the problem?

We should add a check for if policyCategories are null here

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Line 128 in c270b5e

const isLoading = !isOffline && policyCategories === undefined;

Proposal

Please re-state the problem that we are trying to solve in this issue.

Categories load without loading spinner

What is the root cause of that problem?

We have !isLoading set for the state where the categories are empty:

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Lines 179 to 180 in c270b5e

    
           {categoryList.length === 0 && !isLoading && ( 
        
               <WorkspaceEmptyStateSection

But we don't have a !isLoading state for when we list of categories:

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Lines 186 to 187 in c270b5e

    
           {categoryList.length > 0 && ( 
        
               <SelectionList

What changes do you think we should make in order to solve the problem?

We need to add a !isLoading parameter to the list:

{categoryList.length > 0 && !isLoading && (
                        <SelectionList

What alternative solutions did you explore? (Optional)

N/A

I'll test early next week and we can figure out the next steps. Thanks!

@alexpensify

@alexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

No update yet, I need to test.

@alexpensify

bump @alexpensify for review

I've started a discussion in the wave room related to Collect - https://expensify.slack.com/archives/C036QM0SLJK/p1710357619580229. I should have an update by tomorrow.

@luacmartins

PR ready for review @luacmartins @DylanDylann

Reviewing label has been removed, please complete the "BugZero Checklist".

@DylanDylann

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[FIX]: Workspace - Categories load without loading spinner #38849

If no regressions arise, payment will be issued on 2024-04-05. 🎊

For reference, here are some details about the assignees on this issue:

@GandalfGwaihir requires payment automatic offer (Contributor)
@DylanDylann requires payment automatic offer (Reviewer)

@DylanDylann

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@DylanDylann] Determine if we should create a regression test for this bug.
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

I confirmed the job link works here. I'll complete the payment process tomorrow.

https://www.upwork.com/jobs/~01197fc8d66a9362f0

@DylanDylann

Payouts due: 2024-04-05

Contributor: $125 @GandalfGwaihir
Contributor+: $125 @DylanDylann

Upwork job is here.

Closing - Everyone has been paid here

Navigation Menu

Repository navigation

[HOLD for payment 2024-04-05] [$125] Workspace - Categories load without loading spinner #37904

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

39 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	{isLoading && (
	<ActivityIndicator
	size={CONST.ACTIVITY_INDICATOR_SIZE.LARGE}
	style={[styles.flex1]}
	color={theme.spinner}
	/>
	)}

	{categoryList.length === 0 && !isLoading && (
	<WorkspaceEmptyStateSection

[HOLD for payment 2024-04-05] [$125] Workspace - Categories load without loading spinner #37904

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Mar 7, 2024

izarutskaya commented on Mar 7, 2024

izarutskaya commented on Mar 7, 2024

neonbhai commented on Mar 7, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

allgandalf commented on Mar 8, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

alexpensify commented on Mar 8, 2024

melvin-bot commented on Mar 11, 2024

alexpensify commented on Mar 11, 2024

allgandalf commented on Mar 12, 2024

alexpensify commented on Mar 13, 2024

39 remaining items

allgandalf commented on Mar 22, 2024

melvin-bot commented on Mar 29, 2024

melvin-bot commented on Mar 29, 2024

melvin-bot commented on Mar 29, 2024

alexpensify commented on Apr 4, 2024

alexpensify commented on Apr 5, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions