Repository navigation
Update "Request Money" / "Split bill" to work offline #3792
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Launch the desktop app
- Turn off my internet connection
- Click Global Create > Request Money
Expected Result:
I expect to be able to request money offline, which will be sent to the server after I come back online.
Actual Result:
Endless spinner:
Workaround:
Yes, I can connect to the internet to fix this. However, we set out to build an "offline first" app, so it seems to me that we should fix this.
Platform:
Where is this issue occurring? Every platform.
Version Number: v1.0.73-3
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL: N/A
Slack thread: Here
Activity
MelvinBot commentedon Jun 29, 2021
Triggered auto assignment to @arielgreen (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.MelvinBot commentedon Jun 29, 2021
Triggered auto assignment to @bfitzexpensify (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.Julesssss commentedon Jun 29, 2021
I don't think we have used this functionality outside of messages yet, so that would probably be a wider, separate issue.
I think the expected result here would be that users can navigate through the IOU steps, but should be stuck on the Submit page until the connection has returned.
rushatgabhane commentedon Jun 29, 2021
@Julesssss
In my humble opinion, If the user is stuck on submit page, we wasted their time by making them go through the steps. Request isn't saved, so they'll have to do it again.
An alternative could be to queue the API request and call it when the user is back online. (should be a bad idea if user comes back online after a month?)
Or don't allow the user to request payment, and display an offline message instead.
Julesssss commentedon Jun 29, 2021
IMO the main goal for this issue should be to not block users unnecessarily at the amount page. If the
getCurrencyByIPAPI call fails, then we should simply use a default of USD and allow the user to continue through the flow. Ideally the connection will have returned by the confirmation step, and if not we handle the case gracefully.This would almost be my preference -- but I don't think we should block the user via UI preemptively. If the user hits confirm without a connection, then simple error handling and a message is sufficient -- just as we have implemented on the login page... For example:
No connection, please check and try againI agree that the ideal solution would be to queue the request, but that is a much more complex change that requires further discussion. I'd be happy to create an issue to discuss implementation, but it would most likely not be a high priority right now.
rushatgabhane commentedon Jun 29, 2021
I understand, sounds good.
iwiznia commentedon Jun 29, 2021
IMO this should be exactly like sending a message. If you are offline, we show you some indication that the action was not taken and send it as soon as you come online.
Julesssss commentedon Jun 30, 2021
I agree that is the solution, but the question is whether we make these changes separately, or together:
getCurrencyByIPrequest gracefullyJulesssss commentedon Jun 30, 2021
For 2), we should also implement the logic for chats reports created while offline. It's not specific to Request Money / Split Bills, so we need to update this issue or treat them as separate issues.
parasharrajat commentedon Jun 30, 2021
Yes. creating IOU reports is little involved. Better to break it
iwiznia commentedon Jun 30, 2021
Fine with either way, probably a good idea to break it up since they seem like independent changes.
luacmartins commentedon Jul 8, 2021
Picking up this issue - will implement a USD default and
No connection, please check and try againmessage for now.