You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-03-22] Сhat - On selecting skin tone emoji symbol disappears #38049
Version Number: 1.4.50 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/4417529 Issue reported by: Applause - Internal Team
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@rlinoz FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Please re-state the problem that we are trying to solve in this issue.
Сhat - On selecting skin tone emoji symbol disappears
What is the root cause of that problem?
We return from getEmojiCodeWithSkinColor when !preferredSkinToneIndex is true and the last emoji color code has the index of 0 that's why !preferredSkinToneIndex becomes true.
Offending PR: #34487
@Krishna2323 you also updated the proposal so I think you also commented Proposal Updated, I just cleaned up the condition the RCA is still not updated and the original proposal also works without an update
changed the title [-]Сhat - On selecting skin tone emoji symbol disappears[/-][+][HOLD for payment 2024-03-22] Сhat - On selecting skin tone emoji symbol disappears[/+]on Mar 15, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.52-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Activity
github-actions commentedon Mar 11, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Mar 11, 2024
Triggered auto assignment to @rlinoz (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.lanitochka17 commentedon Mar 11, 2024
@rlinoz FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Mar 11, 2024
We think that this bug might be related to #vip-vsp
CC @quinthar
suneox commentedon Mar 11, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Сhat - On selecting skin tone emoji symbol disappears
What is the root cause of that problem?
We have a logic at this line return undefined if the skin tone index is 0
What changes do you think we should make in order to solve the problem?
Instead of check
!preferredSkinToneIndexwe can checkpreferredSkinToneIndex === undefinedorpreferredSkinToneIndex === nullPOC
Screen.Recording.2024-03-11.at.22.12.31.mov
What alternative solutions did you explore? (Optional)
Simple condition
Solution 2
Krishna2323 commentedon Mar 11, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Сhat - On selecting skin tone emoji symbol disappears
What is the root cause of that problem?
We return from
getEmojiCodeWithSkinColorwhen!preferredSkinToneIndexis true and the last emoji color code has the index of 0 that's why!preferredSkinToneIndexbecomes true.Offending PR: #34487
App/src/libs/EmojiUtils.ts
Line 245 in 3d4504e
What changes do you think we should make in order to solve the problem?
Instead of
!preferredSkinToneIndexwe should check fortypeof preferredSkinToneIndex !== 'number'.Result
Alternatively
Create a else statement here and return.
App/src/libs/EmojiUtils.ts
Lines 251 to 253 in 3d4504e
Alternative 2
Change the condition to:
Krishna2323 commentedon Mar 11, 2024
@suneox, you updated your proposal after mine, pls comment
Proposal Updated.suneox commentedon Mar 11, 2024
@Krishna2323 you also updated the proposal so I think you also commented
Proposal Updated, I just cleaned up the condition the RCA is still not updated and the original proposal also works without an updateaimane-chnaif commentedon Mar 11, 2024
For deploy blockers, offending PR should be pointed out in root cause
Krishna2323 commentedon Mar 11, 2024
Offending PR: #34487
suneox commentedon Mar 11, 2024
PR #34487
7 remaining items
rlinoz commentedon Mar 11, 2024
As @aimane-chnaif pointed out this should be handled by @kubabutkiewicz if possible.
kubabutkiewicz commentedon Mar 12, 2024
I will take a look on this today @rlinoz
kubabutkiewicz commentedon Mar 12, 2024
PR ready @rlinoz
[-]Сhat - On selecting skin tone emoji symbol disappears[/-][+][HOLD for payment 2024-03-22] Сhat - On selecting skin tone emoji symbol disappears[/+]melvin-bot commentedon Mar 15, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 15, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.52-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-03-22. 🎊
rlinoz commentedon Mar 15, 2024
No payment due, closing.