Skip to content

[HOLD for payment 2024-04-05] [QAB] Create the Quick Action button #38050

Closed

Description

@Gonals

As described in this section of the design doc, we want to add a Quick Action button to Global Create.

The changes to skip the confirmation screen will be done in a different issue

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01244e26ed86f405a4
  • Upwork Job ID: 1767202396900225024
  • Last Price Increase: 2024-03-11

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    NewFeatureSomething to build that is a new item.
    on Mar 11, 2024
  2. melvin-bot commented on Mar 11, 2024

    @melvin-bot
  3. melvin-bot commented on Mar 11, 2024

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

  4. melvin-bot commented on Mar 11, 2024

    @melvin-bot
  5. moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collecton Mar 12, 2024
  6. joekaufmanexpensify commented on Mar 18, 2024

    @joekaufmanexpensify
    Contributor

    Held.

  7. changed the title [-][HOLD][QAB] Create the Quick Action button[/-] [+][HOLD #377602][QAB] Create the Quick Action button[/+] on Mar 18, 2024
  8. self-assigned this
    on Mar 19, 2024
  9. changed the title [-][HOLD #377602][QAB] Create the Quick Action button[/-] [+][QAB] Create the Quick Action button[/+] on Mar 19, 2024
  10. 21 remaining items

  11. joekaufmanexpensify commented on Apr 9, 2024

    @joekaufmanexpensify
    Contributor

    Actually, I see we have a detailed manual testing script here that covers this case (any others) in more detail. @trjExpensify @Gonals I assume the plan is to just pass off that script to applause to make tests for all of the various cases at once after testing?

    If so, I'll hold off on creating any tests here.

  12. joekaufmanexpensify commented on Apr 9, 2024

    @joekaufmanexpensify
    Contributor

    In the meantime, only payment here is $500 to @parasharrajat via NewDot for C+ review. Could you please request that and confirm here once complete?

  13. trjExpensify commented on Apr 9, 2024

    @trjExpensify
    Contributor

    Actually, I see we have a detailed manual testing script here that covers this case (any others) in more detail. @trjExpensify @Gonals I assume the plan is to just pass off that script to applause to make tests for all of the various cases at once after testing?

    Yep, that's the plan once we're done with the issues for the project!

  14. joekaufmanexpensify commented on Apr 9, 2024

    @joekaufmanexpensify
    Contributor

    Cool. TY!

  15. joekaufmanexpensify commented on Apr 10, 2024

    @joekaufmanexpensify
    Contributor

    Bump @parasharrajat for when you have a sec!

  16. parasharrajat commented on Apr 10, 2024

    @parasharrajat
    Member

    @joekaufmanexpensify I will request that later. Feel free to close it. Thanks.

  17. joekaufmanexpensify commented on Apr 10, 2024

    @joekaufmanexpensify
    Contributor

    Got it. TY! Payment summary is here.

  18. moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collecton Apr 10, 2024
  19. parasharrajat commented on May 20, 2024

    @parasharrajat
    Member

    As per this thread https://expensify.slack.com/archives/C02NK2DQWUX/p1715272276516799?thread_ts=1715190852.677769&cid=C02NK2DQWUX, the price should be 500 for this issue. @joekaufmanexpensify

    Could you please update that on the summary?

  20. joekaufmanexpensify commented on May 21, 2024

    @joekaufmanexpensify
    Contributor

    Brought to slack to discuss

  21. joekaufmanexpensify commented on May 22, 2024

    @joekaufmanexpensify
    Contributor

    Discussed, and confirmed that @parasharrajat is actually due $500 here, since this issue was opened prior to the adjustment of base review price from $500 > $250.

  22. joekaufmanexpensify commented on May 22, 2024

    @joekaufmanexpensify
    Contributor

    Adjust payment summary to reflect that, which is noted here.

  23. parasharrajat commented on Jun 10, 2024

    @parasharrajat
    Member

    Payment requested as per #38050 (comment)

  24. JmillsExpensify commented on Jun 11, 2024

    @JmillsExpensify
    Contributor

    $500 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staffNewFeatureSomething to build that is a new item.

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions