Skip to content

[HOLD for payment 2024-04-22] [$500] Group - All 8 participants are shown in header on creating group #38052

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #37907

Version Number: 1.4.50-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. Tap fab ---- start chat
  3. Add to group 8 participants with small user name
  4. Tap create group

Expected Result:

When creating group with 8 participants, the group conversation header must display only 5 participants

Actual Result:

When creating group with 8 participants, the group conversation header displays all 8 participants

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6409738_1710168322316!IMG_20240311_201422

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019807d7b57314faa7
  • Upwork Job ID: 1768350318226415616
  • Last Price Increase: 2024-03-14
  • Automatic offers:
    • Pujan92 | Reviewer | 0

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 11, 2024
  2. melvin-bot commented on Mar 11, 2024

    @melvin-bot

    Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. lanitochka17 commented on Mar 11, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp
    CC @quinthar

  4. lanitochka17 commented on Mar 11, 2024

    @lanitochka17
    Author

    @anmurali FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. mountiny commented on Mar 11, 2024

    @mountiny
    Contributor

    cc @jbroma @deetergp as this was found during QAing of PR you have been involved at, thanks!

  6. dragnoir commented on Mar 11, 2024

    @dragnoir
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    All selected participants are displayed on the header (names)

    What is the root cause of that problem?

    The headerView component display all the available 8 participants.

    What changes do you think we should make in order to solve the problem?

    We can limit the number of participants to 5 here

    const participants = isSelfDM ? [session?.accountID ?? -1] : report?.participantAccountIDs ?? [];

  7. self-assigned this
    on Mar 11, 2024
  8. deetergp commented on Mar 13, 2024

    @deetergp
    Contributor

    Still sorting this one out on the original GH.

  9. dragnoir commented on Mar 14, 2024

    @dragnoir
    Contributor

    @deetergp I posted a comment here #37907 (comment) to explain how I think that the original GH is not solving the real issue

  10. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 14, 2024
  11. changed the title [-]Group - All 8 participants are shown in header on creating group[/-] [+][$500] Group - All 8 participants are shown in header on creating group[/+] on Mar 14, 2024
  12. 26 remaining items

  13. dragnoir commented on Apr 11, 2024

    @dragnoir
    Contributor

    @anmurali can you pls proceed the payment? Thank you

  14. dragnoir commented on Apr 15, 2024

    @dragnoir
    Contributor

    @anmurali Friendly bump

  15. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    ReviewingHas a PR in review
    on Apr 22, 2024
  16. changed the title [-][$500] Group - All 8 participants are shown in header on creating group[/-] [+][HOLD for payment 2024-04-22] [$500] Group - All 8 participants are shown in header on creating group[/+] on Apr 22, 2024
  17. anmurali commented on Apr 23, 2024

    @anmurali

    @dragnoir - offer is here

  18. dragnoir commented on Apr 23, 2024

    @dragnoir
    Contributor

    @anmurali accepted. Thank you

  19. anmurali commented on Apr 23, 2024

    @anmurali

    Paid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions