Skip to content

[HOLD for payment 2024-04-09] [Simplified Collect][Workflows] Bank account info still displayed in Make or track payments after disconnecting #38200

New issue
New issue
Closed
Closed
[HOLD for payment 2024-04-09] [Simplified Collect][Workflows] Bank account info still displayed in Make or track payments after disconnecting#38200
Assignees
nkuochbfitzexpensifygetusha
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Description

@kavimuru
kavimuru
opened on Mar 13, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.51-1
Reproducible in staging?: y
Reproducible in production?: unable to check in production
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: applause internal team
Slack conversation:

Action Performed:

precondition: user created a paid policy in OD and added a bank account

  1. Go to https://staging.new.expensify.com/
    and log in
  2. Select the paid policy workspace in the workspace switcher > Settings
  3. Click on Workflow
  4. Enable Make or track payments toggle
  5. Select Bank account
  6. Click on the Bank account option > Disconnect

Expected Result:

The bank account information disappears, and "Connect bank account" is displayed

Actual Result:

The bank account information is still displayed even after refreshing the page. Also, after disconnecting the bank account, toggling off/on the "Make or track payments" option, and clicking on bank account the disconnected bank account shows up.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6411594_1710279276937.Recording__282.mp4

View all open jobs on GitHub

Activity

  1. kavimuru
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 13, 2024
  2. melvin-bot
    assigned
    bfitzexpensify
    on Mar 13, 2024

  3. melvin-bot commented on Mar 13, 2024

    @melvin-bot
    melvin-botBot
    on Mar 13, 2024 – with Melvin Bot

    Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Mar 13, 2024

  5. github-actions commented on Mar 13, 2024

    @github-actions
    github-actionsBot
    on Mar 13, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  6. kavimuru commented on Mar 13, 2024

    @kavimuru
    kavimuru
    on Mar 13, 2024
    Author

    @bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  7. melvin-bot
    assigned
    robertjchen
    on Mar 13, 2024

  8. melvin-bot commented on Mar 13, 2024

    @melvin-bot
    melvin-botBot
    on Mar 13, 2024 – with Melvin Bot

    Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  9. kavimuru commented on Mar 13, 2024

    @kavimuru
    kavimuru
    on Mar 13, 2024
    Author

    We think this bug might be related to #wave-collect - Release cc @trjExpensify

  10. robertjchen
    removed
    DeployBlockerCashThis issue or pull request should block deployment
    HourlyKSv2
    on Mar 13, 2024

  11. 28 remaining items

  12. melvin-bot commented on Apr 2, 2024

    @melvin-bot
    melvin-botBot
    on Apr 2, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Apr 2, 2024

    @melvin-bot
    melvin-botBot
    on Apr 2, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-09. 🎊

    For reference, here are some details about the assignees on this issue:

    • @getusha requires payment (Needs manual offer from BZ)

  14. melvin-bot commented on Apr 2, 2024

    @melvin-bot
    melvin-botBot
    on Apr 2, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@getusha] The PR that introduced the bug has been identified. Link to the PR:
    • [@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@getusha] Determine if we should create a regression test for this bug.
    • [@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  15. melvin-bot commented on Apr 2, 2024

    @melvin-bot
    melvin-botBot
    on Apr 2, 2024 – with Melvin Bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  16. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Apr 8, 2024

  17. bfitzexpensify commented on Apr 9, 2024

    @bfitzexpensify
    bfitzexpensify
    on Apr 9, 2024
    Contributor

    @nkuoch mind taking a look at #39439?

  18. melvin-bot commented on Apr 9, 2024

    @melvin-bot
    melvin-botBot
    on Apr 9, 2024 – with Melvin Bot

    Payment Summary

    Upwork Job

    • ROLE: @getusha paid $(AMOUNT) via Upwork (LINK)

    BugZero Checklist (@bfitzexpensify)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct

  19. bfitzexpensify commented on Apr 11, 2024

    @bfitzexpensify
    bfitzexpensify
    on Apr 11, 2024
    Contributor

    Offer sent @getusha

  20. melvin-bot
    added
    Overdue
    on Apr 15, 2024

  21. getusha commented on Apr 16, 2024

    @getusha
    getusha
    on Apr 16, 2024
    Contributor

    @bfitzexpensify accepted

  22. melvin-bot
    removed
    Overdue
    on Apr 16, 2024

  23. bfitzexpensify commented on Apr 16, 2024

    @bfitzexpensify
    bfitzexpensify
    on Apr 16, 2024
    Contributor

    Payment complete. I don't think a regression test is necessary here. Let's close this out.

  24. bfitzexpensify
    closed this as completedon Apr 16, 2024
  25. github-project-automation
    moved this from Polish to Done in [#whatsnext] #wave-collecton Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions