[$500] Android - Log-Unable to share log as tapping on conversation does not trigger any action

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.51
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4422072
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Launch app
Login with a new account
Tap profile --- about --- troubleshoot
Enable client side logging
Tap view debug console
Note logs are displayed in real-time
Enter 5+5
Tap execute
Tap save log
Close the successfully downloaded modal
Tap " Share log"
In search page, tap on a conversation

Expected Result:

In search page, tapping on a conversation user must be directed to conversation page and logs must be sent as an attachment.

Actual Result:

In search page, tapping on a conversation does not trigger any action. User is not navigated to conversation page showing logs sent as an attachment.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6411980_1710314637190.ah.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01c66f93b0f705d0fa
Upwork Job ID: 1768329032101048320
Last Price Increase: 2024-03-14

@stephanieelliott

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@stephanieelliott

@stephanieelliott I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Log-Unable to share log as tapping on conversation does not trigger any action

What is the root cause of that problem?

Here we return early if reportID is not exist. And this can happen if users have not had conversation before

What changes do you think we should make in order to solve the problem?

Create new report if there is not exist old one. To do that we can do below steps

Add return report.reportID at the end of the navigateToAndOpenReport function.
Update the attachLogToReport function like below

    const attachLogToReport = (option: Report) => {
        let reportId = option.reportID
        if (!reportId) {
            reportId = navigateToAndOpenReport([option.login])
        }
        
        const filename = FileUtils.appendTimeToFileName('logs.txt');

        onAttachLogToReport(reportId, filename);
    };

What alternative solutions did you explore? (Optional)

Remove this code .
Add new optional callback param for navigateToAndOpenReport function. And add following code callback?.(report.reportID) after this line
Update this function with below

    const onAttachLogToReport = (option: OptionData, filename: string) => {
        function sendAttachment (reportID: string){
            FileUtils.readFileAsync(
                logSource,
                filename,
                (file) => {
                    Report.addAttachment(reportID, file);

                    const routeToNavigate = ROUTES.REPORT_WITH_ID.getRoute(reportID);
                    Navigation.navigate(routeToNavigate);
                },
                () => {},
            );
        }


        if (!option.reportID) {
            Report.navigateToAndOpenReport([option.login], false, sendAttachment );
            return
        }

        sendAttachment(option.reportID)
    };

Job added to Upwork: https://www.upwork.com/jobs/~01c66f93b0f705d0fa

@situchan

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

@situchan

Yea I think this may be a BE issue -- @situchan can you help me confirm?

This is frontend issue

@shahinyan11

@shahinyan11 does this happen only on android or all platforms?

@shahinyan11

@shahinyan11 does this happen only on android or all platforms?

On all platforms

// Assuming this is within an Adapter for a RecyclerView
@Override
public void onBindViewHolder(@NonNull ViewHolder holder, int position) {
    Conversation conversation = conversations.get(position);

    holder.itemView.setOnClickListener(v -> {
        Intent intent = new Intent(context, ConversationActivity.class);
        intent.putExtra("logData", logData); // Assume logData is a String or serializable object
        context.startActivity(intent);
    });
}

In your ConversationActivity, you would then retrieve the log data:

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_conversation);

    // Retrieve the log data
    String logData = getIntent().getStringExtra("logData");
    // Now you can use logData, e.g., display it or attach it to a message
}

📣 @Eros472! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unable to share log as tapping on conversation does not trigger any action.

What is the root cause of that problem?

When selecting a user with no existing report, the report ID in the option is null which leads to no navigation based on the existing logic.

App/src/pages/settings/AboutPage/ShareLogList/BaseShareLogList.tsx

Lines 106 to 114 in f84219f

    
           const attachLogToReport = (option: Report) => { 
        
               if (!option.reportID) { 
        
                   return; 
        
               } 
        
               const filename = FileUtils.appendTimeToFileName('logs.txt'); 
        
               onAttachLogToReport(option.reportID, filename); 
        
           };

App/src/pages/settings/AboutPage/ShareLogList/index.native.tsx

Lines 9 to 18 in f84219f

    
           const onAttachLogToReport = (reportID: string, filename: string) => { 
        
               if (!reportID || !logSource) { 
        
                   return; 
        
               } 
        
               const src = `file://${logSource}`; 
        
               Report.addAttachment(reportID, {name: filename, source: src, uri: src, type: 'text/plain'} as File); 
        
               const routeToNavigate = ROUTES.REPORT_WITH_ID.getRoute(reportID); 
        
               Navigation.navigate(routeToNavigate); 
        
           };

What changes do you think we should make in order to solve the problem?

The report ID check can be removed.

const attachLogToReport = (option: Report) => {
        const filename = FileUtils.appendTimeToFileName('logs.txt');

        onAttachLogToReport(option, filename);
    };

Instead of having reportID in onAttachLogToReport, we will have option and then call navigateToAndOpenReport with the file.

-     const onAttachLogToReport = (reportID: string, filename: string) => {
+ const onAttachLogToReport = (option: OptionData, filename: string) => {
        FileUtils.readFileAsync(
            logSource,
            filename,
            (file) => {
- Report.addAttachment(reportID, file);

-              const routeToNavigate = ROUTES.REPORT_WITH_ID.getRoute(reportID);
-              Navigation.navigate(routeToNavigate);

+              if (!option.login) {
+                 return;
+              }
+               Report.navigateToAndOpenReport([option.login], true, file)
            },
            () => {},
        );
    };

In navigateToAndOpenReport, we'll pass an option parameter file and then have the below logic after openReport call to add attachment before navigating.

-function navigateToAndOpenReport(userLogins: string[], shouldDismissModal = true) {
+function navigateToAndOpenReport(userLogins: string[], shouldDismissModal = true, file: File = undefined) {
    let newChat: ReportUtils.OptimisticChatReport | EmptyObject = {};

    const participantAccountIDs = PersonalDetailsUtils.getAccountIDsByLogins(userLogins);
    const chat = ReportUtils.getChatByParticipants(participantAccountIDs);

    if (!chat) {
        newChat = ReportUtils.buildOptimisticChatReport(participantAccountIDs);
    }
    const report = chat ?? newChat;

    // We want to pass newChat here because if anything is passed in that param (even an existing chat), we will try to create a chat on the server
    openReport(report.reportID, userLogins, newChat);

+  if (file && report.reportID) {
+      addAttachment(report.reportID, file, '');
+  }
    if (shouldDismissModal) {
        Navigation.dismissModalWithReport(report);
    } else {
        Navigation.navigateWithSwitchPolicyID({route: ROUTES.HOME});
        Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report.reportID));
    }
}

The above was for the web code.
Similar thing can be done for the native code as well.

function ShareLogList({logSource}: ShareLogListProps) {
    const onAttachLogToReport = (option: OptionData, filename: string) => {
        if (!logSource) {
            return;
        }
        const src = `file://${logSource}`;
        if (!option.login) {
            return;
        }
        Report.navigateToAndOpenReport([option.login], true, {name: filename, source: src, uri: src, type: 'text/plain'} as File)
    };

    return <BaseShareLogList onAttachLogToReport={onAttachLogToReport} />;
}

Closing this based on the updated guidance, I think this is somewhat low ROI and can be fixed later when we move to the polish phase.

Navigation Menu

Repository navigation

[$500] Android - Log-Unable to share log as tapping on conversation does not trigger any action #38209

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const attachLogToReport = (option: Report) => {
	if (!option.reportID) {
	return;
	}
	const filename = FileUtils.appendTimeToFileName('logs.txt');

	onAttachLogToReport(option.reportID, filename);
	};

	const onAttachLogToReport = (reportID: string, filename: string) => {
	if (!reportID \|\| !logSource) {
	return;
	}
	const src = `file://${logSource}`;
	Report.addAttachment(reportID, {name: filename, source: src, uri: src, type: 'text/plain'} as File);

	const routeToNavigate = ROUTES.REPORT_WITH_ID.getRoute(reportID);
	Navigation.navigate(routeToNavigate);
	};

[$500] Android - Log-Unable to share log as tapping on conversation does not trigger any action #38209

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Mar 13, 2024

izarutskaya commented on Mar 13, 2024

shahinyan11 commented on Mar 13, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Mar 14, 2024

melvin-bot commented on Mar 14, 2024

stephanieelliott commented on Mar 14, 2024

situchan commented on Mar 14, 2024

situchan commented on Mar 14, 2024

shahinyan11 commented on Mar 14, 2024

Erick4725 commented on Mar 15, 2024

melvin-bot commented on Mar 15, 2024

ShridharGoel commented on Mar 16, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

stephanieelliott commented on Mar 19, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions