Repository navigation
[HOLD for payment 2024-04-05] [Simplified Collect][Workflows] Report preview buttons do not reflect selected Workflow #38254
Description
After Workflows implementation, we need to update the report preview buttons to reflect the selected workflow, i.e. this section of the HL doc:
Update the various conditionals to reflect this
cc @lakchote
Activity
melvin-bot commentedon Mar 13, 2024
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.lakchote commentedon Mar 18, 2024
Updates are still happening, and Carlos will work on this today 🙏
abekkala commentedon Mar 21, 2024
Any update on this one?
31 remaining items
laurenreidexpensify commentedon Apr 8, 2024
Payment Summary:
rushatgabhane commentedon Apr 8, 2024
@laurenreidexpensify i was wondering if the payment would be $500 because this issue was created before change in base price
laurenreidexpensify commentedon Apr 8, 2024
Yip that's valid @rushatgabhane - update:
Payment Summary:
@rushatgabhane requires payment through NewDot Manual Requests $500
laurenreidexpensify commentedon Apr 11, 2024
@rushatgabhane bump for regression test confirmation
@abekkala am unassigning myself now that you back from OOO :)
rushatgabhane commentedon Apr 13, 2024
WIP⚠️
The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again
JmillsExpensify commentedon Apr 13, 2024
$500 approved for @rushatgabhane