Skip to content

[HOLD for payment 2024-03-25] [Wave Collect] [Tags] Tag - Tag row is not grayed out when created offline #38289

New issue
New issue
Closed
Closed
[HOLD for payment 2024-03-25] [Wave Collect] [Tags] Tag - Tag row is not grayed out when created offline#38289
Assignees
slafortuneluacmartinsallroundexpertsmountinyishpaul777
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Description

@izarutskaya
izarutskaya
opened on Mar 14, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Found when validating PR : #38158

Version Number: 1.4.52-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

  • User is an admin of Collect workspace.
  1. Go to staging.new.expensify.com.
  2. Go to Profile > Workspaces > Collect workspace.
  3. Go to Tags.
  4. Go offline.
  5. Click Add tag.
  6. Add a tag.

Expected Result:

Tag row is grayed out when created offline

Actual Result:

Tag row is not grayed out when created offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6413023_1710383772345.bandicam_2024-03-14_10-32-45-394.mp4

View all open jobs on GitHub

Activity

  1. izarutskaya
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 14, 2024
  2. melvin-bot
    assigned
    slafortune
    on Mar 14, 2024

  3. melvin-bot commented on Mar 14, 2024

    @melvin-bot
    melvin-botBot
    on Mar 14, 2024 – with Melvin Bot

    Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Mar 14, 2024

  5. github-actions commented on Mar 14, 2024

    @github-actions
    github-actionsBot
    on Mar 14, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. melvin-bot
    assigned
    madmax330
    on Mar 14, 2024

  7. melvin-bot commented on Mar 14, 2024

    @melvin-bot
    melvin-botBot
    on Mar 14, 2024 – with Melvin Bot

    Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  8. izarutskaya commented on Mar 14, 2024

    @izarutskaya
    izarutskaya
    on Mar 14, 2024
    Author

    @madmax330 I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  9. izarutskaya commented on Mar 14, 2024

    @izarutskaya
    izarutskaya
    on Mar 14, 2024
    Author

    We think that this bug might be related to #wave-collect - Release 1
    CC @trjExpensify

  10. nkdengineer commented on Mar 14, 2024

    @nkdengineer
    nkdengineer
    on Mar 14, 2024
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Tag row is not grayed out when created offline

    What is the root cause of that problem?

    We don't get the pendingAction of tag when get the tag list to display in WorkspaceTagsPage

    App/src/pages/workspace/tags/WorkspaceTagsPage.tsx

    Line 72 in b7a230e

    value: value.name,

    What changes do you think we should make in order to solve the problem?

    We should return an extra field pendingAction: value. pendingAction here.

    App/src/pages/workspace/tags/WorkspaceTagsPage.tsx

    Line 72 in b7a230e

    value: value.name,

    What alternative solutions did you explore? (Optional)

    NA

  11. ikevin127 commented on Mar 14, 2024

    @ikevin127
    ikevin127
    on Mar 14, 2024
    Contributor

    Offending PR #38158 - which is still within the regression period (deployed to staging 17h ago, see #38158 (comment)).

  12. 31 remaining items

  13. melvin-bot
    added
    WeeklyKSv2
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Mar 18, 2024
  14. melvin-bot
    changed the title [-][Wave Collect] [Tags] Tag - Tag row is not grayed out when created offline[/-] [+][HOLD for payment 2024-03-25] [Wave Collect] [Tags] Tag - Tag row is not grayed out when created offline[/+] on Mar 18, 2024
  15. melvin-bot
    removed
    ReviewingHas a PR in review
    on Mar 18, 2024

  16. melvin-bot commented on Mar 18, 2024

    @melvin-bot
    melvin-botBot
    on Mar 18, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  17. melvin-bot commented on Mar 18, 2024

    @melvin-bot
    melvin-botBot
    on Mar 18, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-03-25. 🎊

    For reference, here are some details about the assignees on this issue:

  18. melvin-bot commented on Mar 18, 2024

    @melvin-bot
    melvin-botBot
    on Mar 18, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@allroundexperts / @ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
    • [@allroundexperts / @ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@allroundexperts / @ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@allroundexperts / @ishpaul777] Determine if we should create a regression test for this bug.
    • [@allroundexperts / @ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  19. slafortune commented on Mar 22, 2024

    @slafortune
    slafortune
    on Mar 22, 2024
    Contributor

    @allroundexperts when you get a chance, can you complete the checklist so I can make the payments on Monday?

  20. luacmartins commented on Mar 22, 2024

    @luacmartins
    luacmartins
    on Mar 22, 2024
    Contributor

    No need to regression steps on this one as we'll add it as part of the design doc.

  21. slafortune commented on Mar 22, 2024

    @slafortune
    slafortune
    on Mar 22, 2024
    Contributor

    @ishpaul777 invite sent here

  22. allroundexperts commented on Mar 22, 2024

    @allroundexperts
    allroundexperts
    on Mar 22, 2024
    Contributor

    @slafortune It was decided by @luacmartins and @mountiny that the compensation for #38158 would cover this issue as well. As such, there isn't a payment required here. ref #38289 (comment)

  23. slafortune commented on Mar 22, 2024

    @slafortune
    slafortune
    on Mar 22, 2024
    Contributor

    AH! Thanks for those details @allroundexperts, I missed that! We'll just leave this unit the 25th 👍

  24. ishpaul777 commented on Mar 22, 2024

    @ishpaul777
    ishpaul777
    on Mar 22, 2024
    Contributor

    I haven't accepted the offer yet feel free to withdraw @slafortune

  25. slafortune
    closed this as completedon Mar 27, 2024
  26. github-project-automation
    moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collecton Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions