Repository navigation
Web - No error is displayed under the tag after executing the command in the consol #38410
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.53-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Issue found when executing PR #38332
Action Performed:
- Create a Control workspace in OD
- Enter the following in the console, while the workspace is open:
var p = Policy.getActive();
p.policy.areTagsEnabled = true;
p.save(); - Open ND and go to workspace settings -> tags
- Go offline
- Create a new tag named 'Test'
- Verify that the tag is displayed as greyed out
- (review details below before executing this) Enter the following in the console: Onyx.merge('policyTags_POLICY_ID_HERE', { Tag: { tags: { Test: { errors: { 'test': 'Random error' } } } } })
Expected Result:
An error is displayed below the tag
Actual Result:
No error is displayed under the tag after executing the command in the consol
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6415141_1710520363395.bandicam_2024-03-15_18-22-17-570.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01fdea6ed7743d5caf
- Upwork Job ID: 1780403793249558528
- Last Price Increase: 2024-04-17
Activity
melvin-bot commentedon Mar 15, 2024
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.lanitochka17 commentedon Mar 15, 2024
@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Mar 15, 2024
We think that this bug might be related to #wave-collect - Release 1
mallenexpensify commentedon Mar 15, 2024
Checking on here
mallenexpensify commentedon Mar 18, 2024
Coming from here internally.
The instructions state the following command:
Onyx.merge('policyTags_POLICY_ID_HERE', { Tag: { tags: { Test: { errors: { 'test': 'Random error' } } } } })
Here,
POLICY_ID_HEREneeds to be replaced by the policy id of the testing persons account.They're also not creating a tag with the correct name. It should be
Testand nottestas stated in the instructions.Perhaps I should have been more explicit, considering the fact that the QA people aren't devs. I have updated the steps to clarify the above mistakes.
I added retest-weekly.
mvtglobally commentedon Mar 28, 2024
Issue is reproducible during KI retests.
9 remaining items
melvin-bot commentedon Apr 8, 2024
@mallenexpensify Huh... This is 4 days overdue. Who can take care of this?
mallenexpensify commentedon Apr 10, 2024
Ishpaul helped out in the Slack thread
Okay so we for the scope of this issue we need to test that the error shows up when anything went wrong while creating a tag, usually this only happens in rare case but we have to show error when this happens, To test this we could either execute that code in console or the easisest way QA can test this is with below steps:
Was unable to load the vid here. Need to test again soon.
melvin-bot commentedon Apr 15, 2024
@mallenexpensify Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon Apr 17, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01fdea6ed7743d5caf
melvin-bot commentedon Apr 17, 2024
Triggered auto assignment to Contributor Plus for review of internal employee PR - @jayeshmangwani (
Internal)mallenexpensify commentedon Apr 17, 2024
@jayeshmangwani , can you help me a lil here? I'm a bit at a loss for next steps. Can you reproduce the issue based on the details in the OP and above?
If so, can you snag a vid of the whole process so I can see how it's done? Thx
jayeshmangwani commentedon Apr 17, 2024
@mallenexpensify I think this is not the issue, there is a problem in the testing by QA side
In Issue description, on the 7th step, we are copy/pasting this command
Onyx.merge('policyTags_POLICY_ID_HERE', { Tag: { tags: { Test: { errors: { 'test': 'Random error' } } } } })in browser's console, and in that commandPOLICY_ID_HEREis workspace id,POLICY_IDshould be replaced with that workspace ID for where we are testing the tags, so if workspace id is1,thenpolicyTags_POLICY_ID_HEREwill bepolicyTags_1,And how to obtain the workspace id?
If we are at the tags page, then our browser URL will look something like this
https://staging.new.expensify.com/settings/workspaces/B07DBF42A1CB2406/tags, HereB07DBF42A1CB2406is the workspace ID or we can say POLICY_ID and command will beOnyx.merge('policyTags_B07DBF42A1CB2406', { Tag: { tags: { Test: { errors: { 'test': 'Random error' } } } } })I am getting the error below the Tag, so I think there is no issue but merely a problem with how we are testing.
I am attaching a video of how I am testing.
offline-command-line-tag-error.mov
mallenexpensify commentedon Apr 18, 2024
Thanks @jayeshmangwani , closing as you're not able to reproduce the bug.