Skip to content

[HOLD for payment 2024-08-19] [$500] No feedback and delay when uploading a large attachment #38478

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @neil-marcellini
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1710524006372329

Action Performed:

  1. Use iOS on a slow network connection
  2. Go to any chat
  3. Click the plus button
  4. Add an attachment
  5. Select a video larger than the current limit of 24mb

Expected Result:

"Attachment too large Attachment size is larger than 25 MB limit" popup shows immediately

image

Actual Result:

Nothing happens for quite a while, then you receive a popover explaining that the attachment is too large

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

RPReplay_Final1710521379.MP4
IMG_6440.MOV

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01398c6a10dbc0b325
  • Upwork Job ID: 1770333731300958208
  • Last Price Increase: 2024-07-17
  • Automatic offers:
    • hoangzinh | Reviewer | 0
    • ShridharGoel | Contributor | 0
Issue OwnerCurrent Issue Owner: @Christinadobrzyn / @Christinadobrzyn
Issue OwnerCurrent Issue Owner: @puneetlath / @Christinadobrzyn

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 18, 2024
  2. melvin-bot commented on Mar 18, 2024

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. ShridharGoel commented on Mar 18, 2024

    @ShridharGoel
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    When uploading a large attachment there is a delay on iOS.

    What is the root cause of that problem?

    Image picker library is taking time to fetch the result on IOS.

    To test it out, I had added logs to check time inside imageLibrary method in the native.ts file of the library.

    The time difference was coming between call to launchImageLibrary and getting the result.

    Github issue for some discussion on the same: react-native-image-picker/react-native-image-picker#2117

    What changes do you think we should make in order to solve the problem?

    Add assetRepresentationMode as current.

    const imagePickerOptions = {
        includeBase64: false,
        saveToPhotos: false,
        selectionLimit: 1,
        includeExtra: false,
    +  assetRepresentationMode: 'current'
    };
  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 20, 2024
  5. melvin-bot commented on Mar 20, 2024

    @melvin-bot
  6. changed the title [-]No feedback and delay when uploading a large attachment[/-] [+][$500] No feedback and delay when uploading a large attachment[/+] on Mar 20, 2024
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 20, 2024
  8. Christinadobrzyn commented on Mar 20, 2024

    @Christinadobrzyn
    Contributor

    I can reproduce this. Here's the GH about increasing the size from 24 MB - #32702

    I think this can be external

  9. melvin-bot commented on Mar 20, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

  10. ShridharGoel commented on Mar 20, 2024

    @ShridharGoel
    Contributor

    Proposal

    Updated

  11. 159 remaining items

  12. changed the title [-][$500] No feedback and delay when uploading a large attachment[/-] [+][HOLD for payment 2024-08-19] [$500] No feedback and delay when uploading a large attachment[/+] on Aug 12, 2024
  13. melvin-bot commented on Aug 12, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Aug 12, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-08-19. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on Aug 12, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
    • [@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@hoangzinh] Determine if we should create a regression test for this bug.
    • [@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/421516
  16. Christinadobrzyn commented on Aug 13, 2024

    @Christinadobrzyn
    Contributor

    Payouts due - can we confirm this is the correct payment for this job?

    Do we need a regression test for this @hoangzinh?

  17. hoangzinh commented on Aug 14, 2024

    @hoangzinh
    Contributor

    @Christinadobrzyn, yep I think we need. I will complete BZ checklist soon

  18. hoangzinh commented on Aug 14, 2024

    @hoangzinh
    Contributor

    Regression Test Proposal

    On IOS/Android:

    1. Sign in to any account
    2. Go to any chat
    3. Tap the plus button
    4. Tap "Add an attachment" menu
    5. Select "Chose from gallery"
    6. Select a video larger than the current limit of 24MB
    7. Verify that "Attachment size is larger than 24 MB limit" popup shows immediately

    On Web/Desktop/mWeb:

    1. Sign in to any account
    2. Go to any chat
    3. Tap the plus button
    4. Tap "Add an attachment" menu
    5. Select a video larger than the current limit of 24MB
    6. Verify that "Attachment size is larger than 24 MB limit" popup shows immediately

    Do we agree 👍 or 👎

  19. hoangzinh commented on Aug 14, 2024

    @hoangzinh
    Contributor

    BugZero Checklist:

  20. Christinadobrzyn commented on Aug 19, 2024

    @Christinadobrzyn
    Contributor

    Awesome! Thanks @hoangzinh.

    Regression test - https://github.com/Expensify/Expensify/issues/421516

    This is payment day and there are no regressions so paying this out based on this payment summary

    Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions