You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-08-19] [$500] No feedback and delay when uploading a large attachment #38478
changed the title [-]No feedback and delay when uploading a large attachment[/-][+][$500] No feedback and delay when uploading a large attachment[/+]on Mar 20, 2024
changed the title [-][$500] No feedback and delay when uploading a large attachment[/-][+][HOLD for payment 2024-08-19] [$500] No feedback and delay when uploading a large attachment[/+]on Aug 12, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
[@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@hoangzinh] Determine if we should create a regression test for this bug.
[@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Prevent large attachment #4269 (comment)
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug: ✅ Yes I think we should.
Activity
melvin-bot commentedon Mar 18, 2024
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.ShridharGoel commentedon Mar 18, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
When uploading a large attachment there is a delay on iOS.
What is the root cause of that problem?
Image picker library is taking time to fetch the result on IOS.
To test it out, I had added logs to check time inside
imageLibrarymethod in the native.ts file of the library.The time difference was coming between call to
launchImageLibraryand getting the result.Github issue for some discussion on the same: react-native-image-picker/react-native-image-picker#2117
What changes do you think we should make in order to solve the problem?
Add
assetRepresentationModeascurrent.const imagePickerOptions = { includeBase64: false, saveToPhotos: false, selectionLimit: 1, includeExtra: false, + assetRepresentationMode: 'current' };melvin-bot commentedon Mar 20, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01398c6a10dbc0b325
[-]No feedback and delay when uploading a large attachment[/-][+][$500] No feedback and delay when uploading a large attachment[/+]Christinadobrzyn commentedon Mar 20, 2024
I can reproduce this. Here's the GH about increasing the size from 24 MB - #32702
I think this can be external
melvin-bot commentedon Mar 20, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (
External)ShridharGoel commentedon Mar 20, 2024
Proposal
Updated
159 remaining items
[-][$500] No feedback and delay when uploading a large attachment[/-][+][HOLD for payment 2024-08-19] [$500] No feedback and delay when uploading a large attachment[/+]melvin-bot commentedon Aug 12, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Aug 12, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-19. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Aug 12, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Christinadobrzyn commentedon Aug 13, 2024
Payouts due - can we confirm this is the correct payment for this job?
Do we need a regression test for this @hoangzinh?
hoangzinh commentedon Aug 14, 2024
@Christinadobrzyn, yep I think we need. I will complete BZ checklist soon
hoangzinh commentedon Aug 14, 2024
Regression Test Proposal
On IOS/Android:
On Web/Desktop/mWeb:
Do we agree 👍 or 👎
hoangzinh commentedon Aug 14, 2024
BugZero Checklist:
Christinadobrzyn commentedon Aug 19, 2024
Awesome! Thanks @hoangzinh.
Regression test - https://github.com/Expensify/Expensify/issues/421516
This is payment day and there are no regressions so paying this out based on this payment summary
Closing!