Repository navigation
[HOLD for payment 2024-05-22] [$250] [Simplified Collect][Taxes] - Save button does not move above the keyboard when keyboard is up #38497
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.54-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Precondition:
- User is an admin of Collect workspace
- Go to staging.new.expensify.com
- Go to Profile > Workspaces > Collect workspace
- Go to More features
- Toggle on Taxes
- Tap Add rate
- Tap Name
- Tap on the input field
Expected Result:
Save button will move above the keyboard when keyboard is up
Actual Result:
Save button does not move above the keyboard when keyboard is up
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6418110_1710781609993.Screen_Recording_20240319_010220_New_Expensify.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01f4cc0ef178fa4831
- Upwork Job ID: 1782821416156258304
- Last Price Increase: 2024-05-27
- Automatic offers:
- dukenv0307 | Reviewer | 0
- tienifr | Contributor | 0
Activity
github-actions commentedon Mar 18, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Mar 18, 2024
Triggered auto assignment to @luacmartins (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.lanitochka17 commentedon Mar 18, 2024
@luacmartins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Mar 18, 2024
We think that this bug might be related to #wave-control
luacmartins commentedon Mar 18, 2024
Demoting to NAB since this is for control policies.
luacmartins commentedon Mar 18, 2024
cc @kosmydel @filip-solecki
[-] Taxes - Save button does not move above the keyboard when keyboard is up[/-][+][Simplified Collect][Taxes] - Save button does not move above the keyboard when keyboard is up[/+]96 remaining items
sonialiap commentedon May 17, 2024
Deployed to staging on the 15th
[-][HOLD for payment 2024-05-06] [$125] [Simplified Collect][Taxes] - Save button does not move above the keyboard when keyboard is up[/-][+][HOLD for payment 2024-05-22] [$125] [Simplified Collect][Taxes] - Save button does not move above the keyboard when keyboard is up[/+]sonialiap commentedon May 23, 2024
Payment summary
50% deduction due to regression
$250 / 2 = $125
dukenv0307 commentedon May 24, 2024
@sonialiap Thanks for your summary. As I mentioned before
The price should be 250 as usual. What do you think @luacmartins ?
sonialiap commentedon May 27, 2024
@luacmartins what do you think of the complexity of this issue? Do you think it's reasonable to increase the base price to 250?
luacmartins commentedon May 27, 2024
Sure, we can bump it to $250 given the complexity.
[-][HOLD for payment 2024-05-22] [$125] [Simplified Collect][Taxes] - Save button does not move above the keyboard when keyboard is up[/-][+][HOLD for payment 2024-05-22] [$250] [Simplified Collect][Taxes] - Save button does not move above the keyboard when keyboard is up[/+]melvin-bot commentedon May 27, 2024
Upwork job price has been updated to $250
sonialiap commentedon May 28, 2024
@tienifr Contributor $125 - updated offer sent - paid ✔️
@dukenv0307 Reviewer $125 - updated offer sent - paid ✔️
sonialiap commentedon Jun 4, 2024
@tienifr please accept the offer so that I can complete the payment :)
tienifr commentedon Jun 4, 2024
@sonialiap I accepted it!
sonialiap commentedon Jun 4, 2024
@dukenv0307 please complete the checklist
dukenv0307 commentedon Jun 5, 2024
BugZero Checklist:
Regression test