Skip to content

[HOLD for payment 2024-04-05] [TS migration] Migrate remaining Mock and Script files to TypeScript #38535

Closed

Description

@fabioh8010

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
scripts/release-profile.js 2
mocks/react-native-document-picker.js 0
mocks/@react-native-clipboard/clipboard.js 1

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 18, 2024
  2. melvin-bot commented on Mar 18, 2024

    @melvin-bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. fabioh8010 commented on Mar 19, 2024

    @fabioh8010
    ContributorAuthor

    This issue is internal and will be carried out by the TS team.

  4. VickyStash commented on Mar 19, 2024

    @VickyStash
    Contributor

    Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

  5. joekaufmanexpensify commented on Mar 19, 2024

    @joekaufmanexpensify
    Contributor

    Great. TY!

  6. melvin-bot commented on Mar 22, 2024

    @melvin-bot

    Triggered auto assignment to @madmax330, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  7. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 29, 2024
  8. changed the title [-][TS migration] Migrate remaining Mock and Script files to TypeScript[/-] [+][HOLD for payment 2024-04-05] [TS migration] Migrate remaining Mock and Script files to TypeScript[/+] on Mar 29, 2024
  9. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-05. 🎊

    For reference, here are some details about the assignees on this issue:

  11. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@madmax330] The PR that introduced the bug has been identified. Link to the PR:
    • [@madmax330] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@madmax330] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@VickyStash] Determine if we should create a regression test for this bug.
    • [@VickyStash] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  12. joekaufmanexpensify commented on Mar 29, 2024

    @joekaufmanexpensify
    Contributor

    No payment to issue for TS migration.

  13. joekaufmanexpensify commented on Mar 29, 2024

    @joekaufmanexpensify
    Contributor

    Checklist not needed.

  14. joekaufmanexpensify commented on Mar 29, 2024

    @joekaufmanexpensify
    Contributor

    All set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.Typescript MigrationWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions