You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-04-05] [TS migration] Migrate remaining Mock and Script files to TypeScript #38535
changed the title [-][TS migration] Migrate remaining Mock and Script files to TypeScript[/-][+][HOLD for payment 2024-04-05] [TS migration] Migrate remaining Mock and Script files to TypeScript[/+]on Mar 29, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@madmax330] The PR that introduced the bug has been identified. Link to the PR:
[@madmax330] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@madmax330] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@VickyStash] Determine if we should create a regression test for this bug.
[@VickyStash] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Mar 18, 2024
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.fabioh8010 commentedon Mar 19, 2024
This issue is internal and will be carried out by the TS team.
VickyStash commentedon Mar 19, 2024
Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.
joekaufmanexpensify commentedon Mar 19, 2024
Great. TY!
melvin-bot commentedon Mar 22, 2024
Triggered auto assignment to @madmax330, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
[-][TS migration] Migrate remaining Mock and Script files to TypeScript[/-][+][HOLD for payment 2024-04-05] [TS migration] Migrate remaining Mock and Script files to TypeScript[/+]melvin-bot commentedon Mar 29, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 29, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-04-05. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 29, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
joekaufmanexpensify commentedon Mar 29, 2024
No payment to issue for TS migration.
joekaufmanexpensify commentedon Mar 29, 2024
Checklist not needed.
joekaufmanexpensify commentedon Mar 29, 2024
All set!