[HOLD for payment 2024-05-02] [$500] Incorrect styles in transfer balance> choose account page

@shawnborton

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.54-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1710857164874919

Action Performed:

Open app
Go to profile
Click wallet > transfer balance
Observe the space between "which account" and bank account row
Click on the bank account and go to "choose account" page

Expected Result:

There shouldn't much space between the bank account and "which account" label in step 4
No overflowicon should be present in "choose account" page

Actual Result:

the "Which account?" label on the Transfer balance page seems too far above the bank account row below it
on the Choose account page, we shouldn't be showing the overflow icons. We also need to use our :active BG color for the currently selected bank account row. And there shouldn't be two option rows below for adding a bank account. The first of the two doesn't even work!

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01678d0c2e92d5a68c
Upwork Job ID: 1775846772674859008
Last Price Increase: 2024-04-04
Automatic offers:

hoangzinh | Reviewer | 0

Issue Owner

Current Issue Owner: @miljakljajic

@miljakljajic

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incorrect styles in transfer balance> choose account page

What is the root cause of that problem?

Extra padding.

App/src/pages/settings/Wallet/TransferBalancePage.tsx

Line 191 in 3c204a5

    
           <Text style={[styles.p5, styles.textLabelSupporting, styles.justifyContentStart]}>{translate('transferAmountPage.whichAccount')}</Text>

No styles(padding) for PaymentMethodList. It can be added using listItemStyle or style prop.

App/src/pages/settings/Wallet/ChooseTransferAccountPage.tsx

Lines 60 to 65 in 3c204a5

    
           <PaymentMethodList 
        
               onPress={selectAccountAndNavigateBack} 
        
               shouldShowSelectedState 
        
               filterType={walletTransfer?.filterPaymentMethodType} 
        
               selectedMethodID={walletTransfer?.selectedAccountID} 
        
               shouldShowAddPaymentMethodButton={false}

What changes do you think we should make in order to solve the problem?

Decrease the padding for bottom only or vertically and for PaymentMethodList add padding.

If we want to disable the options also then we need to pass shouldShowAddBankAccount & shouldShowAddPaymentMethodButton as false.

Result

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incorrect styles in transfer balance> choose account page

What is the root cause of that problem?

We have defined a padding of 5:

App/src/pages/settings/Wallet/TransferBalancePage.tsx

Line 191 in 3c204a5

<Text style={[styles.p5, styles.textLabelSupporting, styles.justifyContentStart]}>{translate('transferAmountPage.whichAccount')}</Text>

We only set to false `shouldShowAddPaymentMethodButton1 :

App/src/pages/settings/Wallet/ChooseTransferAccountPage.tsx

Lines 59 to 66 in 3c204a5

    
           <View style={[styles.mt3, styles.flexShrink1, styles.flexBasisAuto]}> 
        
               <PaymentMethodList 
        
                   onPress={selectAccountAndNavigateBack} 
        
                   shouldShowSelectedState 
        
                   filterType={walletTransfer?.filterPaymentMethodType} 
        
                   selectedMethodID={walletTransfer?.selectedAccountID} 
        
                   shouldShowAddPaymentMethodButton={false} 
        
               />

What changes do you think we should make in order to solve the problem?

set pb0 as bottom padding.
We should set shouldShowAddBankAccount to false too

What alternative solutions did you explore? (Optional)

N/A

Proposal Updated

Added fix for PaymentMethodList .

Proposal Updated

Added:

If we want to disable the options also then we need to pass shouldShowAddBankAccount & shouldShowAddPaymentMethodButton as false.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Elements not well styled on Transfer balance steps

What is the root cause of that problem?

For the "Wish account" the padding is wrong.

for the Choose account page, we shouldn't be showing the overflow icons.

What changes do you think we should make in order to solve the problem?

For the "Wish account":

we need to keep the horizontal padding, increase top padding to pt8 and decrease the padding bottom to pt1 here

styles.pt8, styles.ph5, styles.pb1

For the Choose account page:

1- remove overflow icons

Set false to shouldShowRightIcon

App/src/pages/settings/Wallet/PaymentMethodList.tsx

Line 323 in 78db1ae

shouldShowRightIcon={item.shouldShowRightIcon}

2- remove two option rows below for adding a bank account

add shouldShowAddBankAccount={false} to PaymentMethodList to hide the non working option

App/src/pages/settings/Wallet/ChooseTransferAccountPage.tsx

Line 60 in 78db1ae

<PaymentMethodList

3- use our :active BG color for the currently selected bank account row

We don't support background color for the selected MenuItem on our component.
We need to implement this feature, add background color to the item when isSelected.

What alternative solutions did you explore? (Optional)

@shawnborton

@shawnborton you asked about:

We also need to use our :active BG color for the currently selected bank account row.

The component used to display those bank accounts is ActiveItem and it doesn't support a background for the active/selected item.
The background is used when the item is hovered or clicked.
Also, we are using the checkbox active state with the green check to show that the element is selected.

Just wanted to ask if you want to add this feature? bg for selected item.

screenshot on how it's currently without adding background for selected item.

this is how it will look if we add the feature:

Just wanted to ask if you want to add this feature? bg for selected item.

Ah, thanks for explaining that. On second thought, maybe we should not add that because it will look strange when we have multiple users being selected in various flows that also share this component (like starting a chat or splitting something)

Are we keeping this page the way it is? Or still removing the overflow icon?

@miljakljajic

@miljakljajic we need to:
1- remove overflow icons
2- remove two option rows below for adding a bank account
3- adjust the style for the "Wish account"
4- BG color for the currently selected bank account row (Canceled)

@hoangzinh

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix: style of page Transfer balance #39944

If no regressions arise, payment will be issued on 2024-05-02. 🎊

For reference, here are some details about the assignees on this issue:

@hoangzinh requires payment automatic offer (Reviewer)
@dragnoir requires payment (Needs manual offer from BZ)

@hoangzinh

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
[@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@hoangzinh] Determine if we should create a regression test for this bug.
[@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@hoangzinh

@hoangzinh any idea why payment not proceeded here?

@miljakljajic

@miljakljajic would help to process payment for you here on the due date

BugZero Checklist:

The PR that introduced the bug has been identified. Link to the PR: Feature/add assigned card tile and display expensify cards #26862
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/26862/files#r1586932515
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug: No, it's a UI improvement.

ready to pay this out

@hoangzinh

@hoangzinh, @dragnoir, @miljakljajic, @roryabraham Huh... This is 4 days overdue. Who can take care of this?

@hoangzinh

@hoangzinh paid - waiting for @dragnoir to accept the offer.

@miljakljajic

@miljakljajic accepted. Thank you

Paid!

	<PaymentMethodList
	onPress={selectAccountAndNavigateBack}
	shouldShowSelectedState
	filterType={walletTransfer?.filterPaymentMethodType}
	selectedMethodID={walletTransfer?.selectedAccountID}
	shouldShowAddPaymentMethodButton={false}

	<View style={[styles.mt3, styles.flexShrink1, styles.flexBasisAuto]}>
	<PaymentMethodList
	onPress={selectAccountAndNavigateBack}
	shouldShowSelectedState
	filterType={walletTransfer?.filterPaymentMethodType}
	selectedMethodID={walletTransfer?.selectedAccountID}
	shouldShowAddPaymentMethodButton={false}
	/>

[HOLD for payment 2024-05-02] [$500] Incorrect styles in transfer balance> choose account page #38643

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Mar 19, 2024

Krishna2323 commented on Mar 19, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

allgandalf commented on Mar 19, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Krishna2323 commented on Mar 19, 2024

Proposal Updated

Krishna2323 commented on Mar 19, 2024

Proposal Updated

dragnoir commented on Mar 20, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

For the "Wish account":

For the Choose account page:

1- remove overflow icons

2- remove two option rows below for adding a bank account

3- use our :active BG color for the currently selected bank account row

What alternative solutions did you explore? (Optional)

dragnoir commented on Mar 20, 2024

shawnborton commented on Mar 20, 2024

miljakljajic commented on Mar 27, 2024

dragnoir commented on Mar 27, 2024

38 remaining items

melvin-bot commented on Apr 25, 2024

melvin-bot commented on Apr 25, 2024

dragnoir commented on May 1, 2024

hoangzinh commented on May 1, 2024

hoangzinh commented on May 1, 2024

BugZero Checklist:

roryabraham commented on May 6, 2024

melvin-bot commented on May 7, 2024

miljakljajic commented on May 7, 2024

dragnoir commented on May 7, 2024

miljakljajic commented on May 7, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions