[Simplified Collect][Distance rates] Subcategory is displayed as indented instead of Parent: Child format

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Found when validating PR : #38060

Version Number: 1.4.55-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

User is admin of Collect workspace.
The Collect workspace has subcategories.

Go to staging.new.expensify.com.
Go to Profile > Workspaces > Collect workspace.
Go to Distance rates.
Click Settings.
Select a subcategory.

Expected Result:

The selected subcategory in Default category row will be displayed in Parent: Child format.

Actual Result:

The selected subcategory in Default category row is displayed as indented subcategory.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6420279_1710929188630.subcat.mp4

View all open jobs on GitHub

@garrettmknight

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@lakchote

Triggered auto assignment to @lakchote (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@garrettmknight

@garrettmknight I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think this issue might be related to the #wave-control.

@izarutskaya

@izarutskaya How do we create subcategories?

@parasharrajat

@parasharrajat, just by adding a colon, eg: category: subcategory

@parasharrajat

@parasharrajat I think we should use category.searchText here instead of category.text:

App/src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx

Line 48 in c1c054d

    
           Policy.setPolicyDistanceRatesDefaultCategory(policyID, customUnit, {...customUnit, defaultCategory: category.text});

That's consistent with how we select sub-categories in IOU request:

App/src/pages/iou/request/step/IOURequestStepCategory.js

Lines 90 to 92 in c1c054d

    
           const updateCategory = (category) => { 
        
               const isSelectedCategory = category.searchText === transactionCategory; 
        
               const updatedCategory = isSelectedCategory ? '' : category.searchText;

text is for displaying indented space prefix for sub-categories.

I can raise PR immediately if assigned.

I will fix this in the next PR that adds another screen to distance rates feature. Currently its in draft state #38237

Discussed in the thread. The issue is that we aren't showing the parent category in the push row preview, only the indented child category. Here's the comparison with a category on an expense:

Made it to prod today, will test tomo.

@garrettmknight

@garrettmknight, @lakchote, @MrMuzyk 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

This is fixed, closing.

Navigation Menu

Repository navigation

[Simplified Collect][Distance rates] Subcategory is displayed as indented instead of Parent: Child format #38662

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

5 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const updateCategory = (category) => {
	const isSelectedCategory = category.searchText === transactionCategory;
	const updatedCategory = isSelectedCategory ? '' : category.searchText;

[Simplified Collect][Distance rates] Subcategory is displayed as indented instead of Parent: Child format #38662

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Mar 20, 2024

github-actions commented on Mar 20, 2024

melvin-bot commented on Mar 20, 2024

izarutskaya commented on Mar 20, 2024

parasharrajat commented on Mar 20, 2024

Krishna2323 commented on Mar 20, 2024

tienifr commented on Mar 20, 2024

5 remaining items

MrMuzyk commented on Mar 20, 2024

trjExpensify commented on Mar 20, 2024

garrettmknight commented on Mar 27, 2024

melvin-bot commented on Apr 8, 2024

garrettmknight commented on Apr 10, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions