Skip to content

[HOLD for payment 2024-04-05] [$250] [Simplified Collect][Tags] - Deleted tag can be clicked on when deleted offline #38663

New issue
New issue
Closed
Closed
[HOLD for payment 2024-04-05] [$250] [Simplified Collect][Tags] - Deleted tag can be clicked on when deleted offline#38663
Assignees
ntdiaryluacmartinslschurrmountinyKrishna2323
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Description

@izarutskaya
izarutskaya
opened on Mar 20, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v1.4.-55-0
Reproducible in staging?: Y
Reproducible in production?: No, new feature
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

  • User is admin of Collect workspace.
  • The Collect workspace has tags.
  1. Go to staging.new.expensify.com.
  2. Go to Profile > Workspaces > Collect workspace.
  3. Go to Tags.
  4. Go offline.
  5. Click on any tag.
  6. Click 3-dot menu > Delete tag.
  7. Delete the tag.
  8. Click on the deleted tag and rename the tag.

Expected Result:

When a tag is deleted offline, app should prevent user from accessing the deleted tag.

Actual Result:

When a tag is deleted offline, user can access the deleted tag by clicking on it. When renaming a deleted tag, the tag is no longer deleted.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6420281_1710929192481.delete_tag.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0137a327ba3211534e
  • Upwork Job ID: 1770409096694325248
  • Last Price Increase: 2024-03-20
  • Automatic offers:
    • ntdiary | Reviewer | 0
    • Krishna2323 | Contributor | 0
Issue OwnerCurrent Issue Owner: @lschurr

Activity

  1. izarutskaya
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 20, 2024
  2. melvin-bot
    assigned
    lschurr
    on Mar 20, 2024

  3. melvin-bot commented on Mar 20, 2024

    @melvin-bot
    melvin-botBot
    on Mar 20, 2024 – with Melvin Bot

    Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Mar 20, 2024

  5. github-actions commented on Mar 20, 2024

    @github-actions
    github-actionsBot
    on Mar 20, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  6. melvin-bot commented on Mar 20, 2024

    @melvin-bot
    melvin-botBot
    on Mar 20, 2024 – with Melvin Bot

    Triggered auto assignment to @mountiny (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  7. melvin-bot
    assigned
    mountiny
    on Mar 20, 2024

  8. izarutskaya commented on Mar 20, 2024

    @izarutskaya
    izarutskaya
    on Mar 20, 2024
    Author

    @lschurr I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

    We think this issue might be related to the #wave-control.

  9. mountiny
    added
    DailyKSv2
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    HourlyKSv2
    on Mar 20, 2024

  10. 26 remaining items

  11. luacmartins
    self-assigned this
    on Mar 25, 2024

  12. mountiny commented on Mar 27, 2024

    @mountiny
    mountiny
    on Mar 27, 2024
    Contributor

    Ok this will be ready for payment if no regressions $250 to @ntdiary and to @Krishna2323

  13. melvin-bot
    added
    WeeklyKSv2
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    WeeklyKSv2
    on Mar 29, 2024
  14. melvin-bot
    changed the title [-][$250] [Simplified Collect][Tags] - Deleted tag can be clicked on when deleted offline[/-] [+][HOLD for payment 2024-04-05] [$250] [Simplified Collect][Tags] - Deleted tag can be clicked on when deleted offline[/+] on Mar 29, 2024
  15. melvin-bot
    removed
    ReviewingHas a PR in review
    on Mar 29, 2024

  16. melvin-bot commented on Mar 29, 2024

    @melvin-bot
    melvin-botBot
    on Mar 29, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  17. melvin-bot commented on Mar 29, 2024

    @melvin-bot
    melvin-botBot
    on Mar 29, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-05. 🎊

    For reference, here are some details about the assignees on this issue:

  18. melvin-bot commented on Mar 29, 2024

    @melvin-bot
    melvin-botBot
    on Mar 29, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ntdiary] The PR that introduced the bug has been identified. Link to the PR:
    • [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@ntdiary] Determine if we should create a regression test for this bug.
    • [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  19. lschurr commented on Apr 5, 2024

    @lschurr
    lschurr
    on Apr 5, 2024
    Contributor

    Payment summary:

  20. ntdiary commented on Apr 8, 2024

    @ntdiary
    ntdiary
    on Apr 8, 2024
    Contributor

    Contributor+: @ntdiary $250 (please accept the offer in Upwork)

    @lschurr, thank you! Have accepted. 😄

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ntdiary] The PR that introduced the bug has been identified. Link to the PR: Create WorkspaceTagsPage #37621
    • [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/37621/files#r1555481707
    • [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • [@ntdiary] Determine if we should create a regression test for this bug. Don't have strong feeling, but will still provide regression steps first.
    • [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. As below
    • [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

    Regression steps:

    1. Log in with an account that has a collect workspace.
    2. Go to Profile > Workspaces > Collect workspace.
    3. Go to Tags page.
    4. Go offline.
    5. Select any tag, then click 3-dot menu, and then delete that tag.
    6. Hover or click the deleted tag and verify it is disabled with correct stylings.

  21. lschurr commented on Apr 8, 2024

    @lschurr
    lschurr
    on Apr 8, 2024
    Contributor

    Great, we're all set!

  22. lschurr
    closed this as completedon Apr 8, 2024
  23. github-project-automation
    moved this from Polish to Done in [#whatsnext] #wave-collecton Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions