[HOLD for payment 2024-04-05] [$250] Web - Inconsistent behavior when saving existing name without edit

@shubham1206agra

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.55-0
Reproducible in staging?: y
Reproducible in production?: new feature
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

User is admin of Collect workspace.
The Collect workspace has categories and tags.

Go to staging.new.expensify.com.
Go to Profile > Workspaces > Collect workspace.
Go to Categories.
Click on any category.
Click Category name.
Save the name without editing.
Note that an error shows up.
Go to Tags.
Click on any tag.
Click Tag name.
Save the name without editing.

Expected Result:

When saving category and tag name without editing, the behavior should be consistent. If error is meant to show up, it should show up for both. Otherwise, there should be no error for both.

For any feature - Category, tag, distance or tax, when the name is being changed but no change has been done, do nothing and just close the modal (skip the API call too)

Actual Result:

In Step 6, error shows up when saving category name without editing it.
In Step 11, no error shows up when saving tag name without editing it.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6420400_1710936083255.20240320_194746.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~017d373a5e049d77c6
Upwork Job ID: 1770442815835451392
Last Price Increase: 2024-03-20
Automatic offers:

GandalfGwaihir | Contributor | 0
shubham1206agra | Contributor | 0

Issue Owner

Current Issue Owner: @shubham1206agra

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@cristipaval

Triggered auto assignment to @cristipaval (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

This is not a blocker, its a new feature, I can take over.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Categories & Tags - Inconsistent behavior when saving existing name without edit

What is the root cause of that problem?

We have duplicate tag check but it is wrong:

App/src/pages/workspace/tags/EditTagPage.tsx

Lines 41 to 50 in 0fa4d0f

    
           const validate = useCallback( 
        
               (values: FormOnyxValues<typeof ONYXKEYS.FORMS.WORKSPACE_TAG_FORM>) => { 
        
                   const errors: FormInputErrors<typeof ONYXKEYS.FORMS.WORKSPACE_TAG_FORM> = {}; 
        
                   const tagName = values.tagName.trim(); 
        
                   const {tags} = PolicyUtils.getTagList(policyTags, 0); 
        
                   if (!ValidationUtils.isRequiredFulfilled(tagName)) { 
        
                       errors.tagName = 'workspace.tags.tagRequiredError'; 
        
                   } else if (tags?.[tagName] && currentTagName !== tagName) { 
        
                       errors.tagName = 'workspace.tags.existingTagError'; 
        
                   }

What changes do you think we should make in order to solve the problem?

Update duplicate category check similar to tag check:

App/src/pages/workspace/categories/CategoryForm.tsx

Lines 42 to 43 in 0fa4d0f

    
           } else if (policyCategories?.[newCategoryName]) { 
        
               errors.categoryName = 'workspace.categories.existingCategoryError';

This check should be updated to:

} else if (policyCategories?.[newCategoryName] && currentCategoryName !== newCategoryName) { 
     errors.categoryName = 'workspace.categories.existingCategoryError';

Now we also shouldn't make a API call if we have made no changes, so update the following:

App/src/pages/workspace/tags/EditTagPage.tsx

Lines 57 to 64 in 0fa4d0f

    
           const editTag = useCallback( 
        
               (values: FormOnyxValues<typeof ONYXKEYS.FORMS.WORKSPACE_TAG_FORM>) => { 
        
                   Policy.renamePolicyTag(route.params.policyID, {oldName: currentTagName, newName: values.tagName.trim()}); 
        
                   Keyboard.dismiss(); 
        
                   Navigation.dismissModal(); 
        
               }, 
        
               [route.params.policyID, currentTagName], 
        
           );

TO:

 const editTag = useCallback( 
     (values: FormOnyxValues<typeof ONYXKEYS.FORMS.WORKSPACE_TAG_FORM>) => { 
        if(!(policyCategories?.[newCategoryName] && currentCategoryName !== newCategoryName)){
         Policy.renamePolicyTag(route.params.policyID, {oldName: currentTagName, newName: values.tagName.trim()}); 
         }
         Keyboard.dismiss(); 
         Navigation.dismissModal(); 
     }, 
     [route.params.policyID, currentTagName], 
 );

Similar would be done on category page.

What alternative solutions did you explore? (Optional)

N/A

@shubham1206agra

$250 to @GandalfGwaihir and $250 to @shubham1206agra

@slafortune

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@shubham1206agra

@shubham1206agra please accept this offer - https://www.upwork.com/nx/wm/offer/101650388
@GandalfGwaihir - Paid

@shubham1206agra

@shubham1206agra please accept this offer - https://www.upwork.com/nx/wm/offer/101650388

I'll be out of the office until 4/22 and will check on this then.

@slafortune

@slafortune Accepted the offer.

@slafortune

Bump to @slafortune to close this one once @shubham1206agra gets paid :)

Yep, just back today! Paid and closing ✔️

Navigation Menu

Repository navigation

[HOLD for payment 2024-04-05] [$250] Web - Inconsistent behavior when saving existing name without edit #38668

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

51 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const validate = useCallback(
	(values: FormOnyxValues<typeof ONYXKEYS.FORMS.WORKSPACE_TAG_FORM>) => {
	const errors: FormInputErrors<typeof ONYXKEYS.FORMS.WORKSPACE_TAG_FORM> = {};
	const tagName = values.tagName.trim();
	const {tags} = PolicyUtils.getTagList(policyTags, 0);
	if (!ValidationUtils.isRequiredFulfilled(tagName)) {
	errors.tagName = 'workspace.tags.tagRequiredError';
	} else if (tags?.[tagName] && currentTagName !== tagName) {
	errors.tagName = 'workspace.tags.existingTagError';
	}

	} else if (policyCategories?.[newCategoryName]) {
	errors.categoryName = 'workspace.categories.existingCategoryError';

	const editTag = useCallback(
	(values: FormOnyxValues<typeof ONYXKEYS.FORMS.WORKSPACE_TAG_FORM>) => {
	Policy.renamePolicyTag(route.params.policyID, {oldName: currentTagName, newName: values.tagName.trim()});
	Keyboard.dismiss();
	Navigation.dismissModal();
	},
	[route.params.policyID, currentTagName],
	);

[HOLD for payment 2024-04-05] [$250] Web - Inconsistent behavior when saving existing name without edit #38668

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

github-actions commented on Mar 20, 2024

melvin-bot commented on Mar 20, 2024

mountiny commented on Mar 20, 2024

allgandalf commented on Mar 20, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

51 remaining items

mountiny commented on Mar 29, 2024

melvin-bot commented on Mar 29, 2024

slafortune commented on Apr 5, 2024

slafortune commented on Apr 11, 2024

slafortune commented on Apr 15, 2024

shubham1206agra commented on Apr 17, 2024

allgandalf commented on Apr 23, 2024

slafortune commented on Apr 23, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions