Repository navigation
[Guided Setup Stage 2] Update HandleSpecialChatReportsOnMergeAccount to handle system DM #38770
Description
Part of the "wave-collect – Build Stage 2 of Guided Setup" project
Main issue: https://github.com/Expensify/Expensify/issues/356685
Doc section: https://docs.google.com/document/d/10bhCv6XtzzqEZQ9tzxFwAz4lowgjOhsFqz13BMq6Iu4/edit#heading=h.dmxmb440p80k (and section below)
Project: [#whatsnext] #wave-collect
Feature Description
- Create the concept of read-only messages by updating the permissions mechanism
- Create a read-only system DM using the new Expensify persona for existing and new users
Remaining tasks
-
MakeAccount writing to chat/task report without permissionthrow - Handle MergeAccount
- Update HandleSpecialChatReportsOnMergeAccount to handle system DM
- Remove HandleSelfDMOnMergeAccount from AuthCommandMap
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~010dca0075d6efe79d
- Upwork Job ID: 1770904803490025472
- Last Price Increase: 2024-03-21
Activity
melvin-bot commentedon Mar 21, 2024
Job added to Upwork: https://www.upwork.com/jobs/~010dca0075d6efe79d
melvin-bot commentedon Mar 21, 2024
Triggered auto assignment to Contributor Plus for review of internal employee PR - @getusha (
Internal)melvin-bot commentedon Mar 21, 2024
Triggered auto assignment to @CortneyOfstad (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.melvin-bot commentedon Mar 21, 2024
francoisl commentedon Mar 21, 2024
This is all backend work and will be taken care of internally, no need for a C+ here.
95 remaining items
NikkiWines commentedon Sep 11, 2024
Discussing with @francoisl today about whether or not we want to update this command to
A. Take in the type of special chat report we'd want to merge (i.e. system, selfDM, etc.)
or
B. Merge all the special type DMs in one go instead of passing a specific type.
Not sure if we have a scenario where we'd want to merge the selfDM but not system DM, since this is called when the user merges their account. So I'm leaning more towards B at the moment
francoisl commentedon Sep 12, 2024
I'd say option
B, otherwise we'd need that command twice (once for self DMs, once for system DMs).NikkiWines commentedon Sep 13, 2024
PR is in the works! Draft is up here
NikkiWines commentedon Sep 17, 2024
Logic is working as expected, finishing up tests tomorrow morning
NikkiWines commentedon Sep 18, 2024
PR is in review!
NikkiWines commentedon Sep 24, 2024
PR has been merged!
trjExpensify commentedon Sep 25, 2024
Dope, deployed. Good to close?
NikkiWines commentedon Sep 26, 2024
Yes should be all set here!
trjExpensify commentedon Sep 30, 2024
Wahoo!