Repository navigation
[HOLD for payment 2024-04-05] [Distance rates] Immediate editing of freshly created rate fails - rates are not being created with correct optimistic name #38798
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
Action Performed:
- Create distance rates with same rate value and try to quickly disable last created rate
Expected Result:
- User can edit created rate immediately without any issues
Actual Result:
- Rate is not being edited and error is thrown
Workaround:
Wait a few seconds before editing a rate after it's created
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Activity
melvin-bot commentedon Mar 22, 2024
Triggered auto assignment to @slafortune (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MrMuzyk commentedon Mar 22, 2024
As mentioned in one of the previous PRs for distance rates this will be a followup that fixes it
3 remaining items
[-][Distance rates] Immediate editing of freshly created rate fails - rates are not being created with correct optimistic name[/-][+][HOLD for payment 2024-04-05] [Distance rates] Immediate editing of freshly created rate fails - rates are not being created with correct optimistic name[/+]melvin-bot commentedon Mar 29, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 29, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-04-05. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 29, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Apr 5, 2024
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
luacmartins commentedon Apr 5, 2024
@trjExpensify we need to pay @c3024 for the PR review
trjExpensify commentedon Apr 10, 2024
Cool! Payment summary as follows:
trjExpensify commentedon Apr 10, 2024
Paid!