[HOLD for payment 2024-04-15] [$500] Distance - Unable to save second distance edit offline

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.56-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

Go to staging.new.expensify.com.
Go to workspace chat.
Create a distance request with three waypoints.
Go to request details page.
Go offline.
Click Distance.
Drag and drop the waypoints and save it.
Repeat Step 6 and 7.

Expected Result:

User will be able to save the second distance edit.

Actual Result:

User is unable to save the second distance edit.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6423379_1711125466153.20240323_001712.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b020e3127d156e8f
Upwork Job ID: 1772031538674204672
Last Price Increase: 2024-03-24
Automatic offers:

GandalfGwaihir | Contributor | 0

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@srikarparsi

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

We think that this bug might be related to #wave-collect - Release 1

Proposal

Please re-state the problem that we are trying to solve in this issue.

User is unable to save the second distance edit.

What is the root cause of that problem?

We prevent the user save the distance if the transaction is loading.

App/src/pages/iou/request/step/IOURequestStepDistance.js

Lines 190 to 192 in 7f5cf61

    
           if (duplicateWaypointsError || atLeastTwoDifferentWaypointsError || hasRouteError || isLoadingRoute || isLoading) { 
        
               setShouldShowAtLeastTwoDifferentWaypointsError(true); 
        
               return;

So in offline, after the first time we edit the distance, we can't edit this anymore.

What changes do you think we should make in order to solve the problem?

As the old edit distance flow, we should allow user saving the distance if we're offline event the transaction is loading

if (duplicateWaypointsError || atLeastTwoDifferentWaypointsError || hasRouteError || isLoadingRoute || (isLoading && !isOffline)) {
    setShouldShowAtLeastTwoDifferentWaypointsError(true);
    return;
}

App/src/pages/iou/request/step/IOURequestStepDistance.js

Lines 190 to 192 in 7f5cf61

    
           if (duplicateWaypointsError || atLeastTwoDifferentWaypointsError || hasRouteError || isLoadingRoute || isLoading) { 
        
               setShouldShowAtLeastTwoDifferentWaypointsError(true); 
        
               return;

What alternative solutions did you explore? (Optional)

NA

Looks like a regression from this PR
#35302

@DylanDylann

Tagging @DylanDylann @cubuspl42 for visibility.

This looks external since editing the order of the points does work while offline when creating the request. Opening it up to see if there's any proposals before Monday.

@GandalfGwaihir can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01b020e3127d156e8f

Compensation is 50% of the job price, $250, because authoring a PR and testing wasn't involved.

@mallenexpensify

@mallenexpensify accepted the offer thanks :)

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

📣 @GandalfGwaihir 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

Contributor: @GandalfGwaihir paid $250 via Upwork

Thanks!

@mallenexpensify

I will decline the autogenerated offer by Melvin on Upwork, I was paid already, thanks for the paying @mallenexpensify :)

Navigation Menu

Repository navigation

[HOLD for payment 2024-04-15] [$500] Distance - Unable to save second distance edit offline #38814

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

48 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (duplicateWaypointsError \|\| atLeastTwoDifferentWaypointsError \|\| hasRouteError \|\| isLoadingRoute \|\| isLoading) {
	setShouldShowAtLeastTwoDifferentWaypointsError(true);
	return;

[HOLD for payment 2024-04-15] [$500] Distance - Unable to save second distance edit offline #38814

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

github-actions commented on Mar 22, 2024

melvin-bot commented on Mar 22, 2024

kbecciv commented on Mar 22, 2024

nkdengineer commented on Mar 22, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

ZhenjaHorbach commented on Mar 22, 2024

shubham1206agra commented on Mar 23, 2024

srikarparsi commented on Mar 24, 2024

48 remaining items

mallenexpensify commented on Apr 12, 2024

allgandalf commented on Apr 14, 2024

melvin-bot commented on Apr 15, 2024

melvin-bot commented on Apr 16, 2024

mallenexpensify commented on Apr 16, 2024

allgandalf commented on Apr 16, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions