[HOLD on ISSUE #34616] Web - App crashes when open /participants link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.56-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Go to staging.new.expensify.com
Paste https://staging.new.expensify.com/request/new/participants
into browser address or send it to any report

Expected Result:

Link should lead to participants page

Actual Result:

App crashes when open https://staging.new.expensify.com/request/new/participants

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6423383_1711125665668.Recording__2668.mp4

View all open jobs on GitHub

@muttmuure

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@muttmuure

@muttmuure FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

I think it is a regression from #35455 which remove
ROUTES.MONEY_REQUEST but not remove its usage

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when open /participants link.

What is the root cause of that problem?

navigateBack uses this ROUTES.MONEY_REQUEST.getRoute in MoneyRequestParticipantsPage.js.

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js

Lines 93 to 96 in a8382aa

    
           const navigateBack = useCallback((forceFallback = false) => { 
        
               Navigation.goBack(ROUTES.MONEY_REQUEST.getRoute(iouType, reportID), forceFallback); 
        
               // eslint-disable-next-line react-hooks/exhaustive-deps -- no deps as we use only initial values 
        
           }, []);

getRoute is not defined for ROUTES.MONEY_REQUEST. In fact, MONEY_REQUEST is not even there in this file.

This leads to getRoute being called on undefined object.

What changes do you think we should make in order to solve the problem?

Define ROUTES.MONEY_REQUEST here and also add getRoute for it or use some other route in the goBack method.

We need to hold this for #34616, this will be fixed in that.

Held

@muttmuure

@muttmuure, #34616 has been merged and closed, we can also close this one. The issue has been resolved. Instead of crashing, it now shows 'not found' because the request/new/participants route isn't valid anymore.

Great! Thanks

Navigation Menu

Repository navigation

[HOLD on ISSUE #34616] Web - App crashes when open /participants link #38816

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const navigateBack = useCallback((forceFallback = false) => {
	Navigation.goBack(ROUTES.MONEY_REQUEST.getRoute(iouType, reportID), forceFallback);
	// eslint-disable-next-line react-hooks/exhaustive-deps -- no deps as we use only initial values
	}, []);

[HOLD on ISSUE #34616] Web - App crashes when open /participants link #38816

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Mar 22, 2024

lanitochka17 commented on Mar 22, 2024

ahmedGaber93 commented on Mar 22, 2024

ShridharGoel commented on Mar 22, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Krishna2323 commented on Mar 22, 2024

muttmuure commented on Apr 17, 2024

muttmuure commented on Apr 26, 2024

muttmuure commented on May 1, 2024

Krishna2323 commented on May 1, 2024

muttmuure commented on May 14, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions