Repository navigation
[$500] Task - Chat is not scrolled to bottom when edit a task #38833
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
**Version Number:**1.4.56-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/runs/view/20318&group_by=cases:section_id&group_order=asc&group_id=291935
Email or phone of affected tester (no customers): shussain+web@applausemail.com
Issue reported by: Applause - Internal Team
Action Performed:
- Open an existing chat
- Click the '+' > Assign Task
- Give the task as Title, Description and Assignee > Confirm Task
- Click on the created task in the chat
- Change the name > Save
- Verify there's an audit trail of the change in the chat thread
- Make more changes to the task (you can change the title, description, assignee) > click Save
- Verify that eventually the chat isn't fully scrolled to the bottom of last message (or audit trail change)
Expected Result:
Chat should always scroll to the bottom of the last message ( you should see the last message after making a change)
Actual Result:
After making multiple edits to a task, the chat thread isn't scrolled to the bottom.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6423531_1711133132795.2024-03-22_23-44-10.mp4
2024-03-26_12-57-52.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01d64def74796adc96
- Upwork Job ID: 1772488534557900800
- Last Price Increase: 2024-03-26
- Automatic offers:
- fedirjh | Reviewer | 0
- gijoe0295 | Contributor | 0
Activity
melvin-bot commentedon Mar 22, 2024
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.lanitochka17 commentedon Mar 22, 2024
@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Mar 22, 2024
We think that this bug might be related to #vip-vsp
gijoe0295 commentedon Mar 22, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Chat is not scrolled to bottom when edit a task
What is the root cause of that problem?
Whenever there's any new report action in the report, we should call the
notifyNewAction:App/src/libs/actions/Report.ts
Line 342 in d482a25
to trigger
scrollToBottom:App/src/pages/home/report/ReportActionsList.js
Line 298 in 82da6b5
That's what we've been doing for IOU requests (for eg here). But for edit task flow (
editTask), we did not call it.What changes do you think we should make in order to solve the problem?
Call
Report.notifyNewAction(report.reportID, currentUserAccountID)after editing the task ineditTask.We should also do it for whatever actions create new report action/message in the chat. For example:
editTaskAssignee,reopenTask,completeTask.What alternative solutions did you explore? (Optional)
NA
bernhardoj commentedon Mar 23, 2024
gijoe0295 commentedon Mar 23, 2024
That's not correct @bernhardoj. This is a new behavior not on production and has different RCA with #38855.
Christinadobrzyn commentedon Mar 25, 2024
Hum, I'm not able to reproduce this, it looks like the chat is at the bottom and the cursor is in the chat field when making edits to an assigned task.
2024-03-25_11-36-13.mp4
Asking QA for some clarification on the expected result vs actual result - https://expensify.slack.com/archives/C9YU7BX5M/p1711337939301019
gijoe0295 commentedon Mar 25, 2024
@Christinadobrzyn you need to scroll the task report up then make changes there. They expect that when there're new changes in that task report, it should scroll to bottom (just like regular chat report).
Christinadobrzyn commentedon Mar 26, 2024
Ah okay, I think I'm able to reproduce, I updated the OP so it's clearer how to reproduce. I think this can be external and part of vip-vsb
[-]Task - Chat is not scrolled to bottom when edit a task[/-][+][$500] Task - Chat is not scrolled to bottom when edit a task[/+]25 remaining items
melvin-bot commentedon Apr 2, 2024
📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
melvin-bot commentedon Apr 2, 2024
📣 @gijoe0295 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
gijoe0295 commentedon Apr 19, 2024
@Christinadobrzyn I think we're good for payment here because PR has been on production for nearly 10 days.
Christinadobrzyn commentedon Apr 22, 2024
Thanks @gijoe0295 - not sure why the payment auto-message didn't trigger for this.
Payouts due:
Upwork job is here.
@fedirjh or @gijoe0295 do we need a regression test for this?
fedirjh commentedon Apr 22, 2024
@Christinadobrzyn It seems like this bug was discovered using a regression test. Please review the OP for more information:
Christinadobrzyn commentedon Apr 22, 2024
Ah thanks @fedirjh, if it was caught during a regression test then no payments should be made. I just requested a refund through Upwork for the payments sent earlier today. Let me know if I'm missing anything!
fedirjh commentedon Apr 22, 2024
@Christinadobrzyn Sorry for the confusion. My above answer was related to this question :
We don't need a regression test as we already have one listed in the OP.
This is not the case for this issue. it is not caught during the regression period.
Christinadobrzyn commentedon Apr 23, 2024
Oh thank you for clarifying! Okay, gotcha!
Please ignore my refund requests. Closing since we don't need a regression. Let me know if I'm missing anything.