Skip to content

[HOLD for payment 2024-04-15] [$250] HIGH: [Comment linking] Highlight the linked comment with a different color than the normal hover color #38851

New issue
New issue
Closed
Closed
[HOLD for payment 2024-04-15] [$250] HIGH: [Comment linking] Highlight the linked comment with a different color than the normal hover color#38851
Assignees
shawnbortonPujan92roryabrahamkadiealexandernkdengineer
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2DesignExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Description

@roryabraham
roryabraham
opened on Mar 23, 2024

https://expensify.slack.com/archives/C035J5C9FAP/p1711152608943449?thread_ts=1705035404.136629&cid=C035J5C9FAP

Action Performed:

Click on a link to a comment in any chat.

Expected Result:

  1. You should be linked straight to that comment and be able to load chats in either direction (already built, this is currently on staging)
  2. The comment you linked to should be highlighted in a different color than the normal hover color (temporarily? or permanently?)

Actual Result:

The linked-to comment is highlighted with the color that a message becomes when you hover over it.

Workaround:

n/a

Platforms:

all platforms

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d8f674d9f769e10c
  • Upwork Job ID: 1774424743522938880
  • Last Price Increase: 2024-03-31
  • Automatic offers:
    • Pujan92 | Reviewer | 0
Issue OwnerCurrent Issue Owner: @Pujan92

Activity

  1. roryabraham
    added
    DailyKSv2
    WeeklyKSv2
    NewFeatureSomething to build that is a new item.
    Design
    on Mar 23, 2024
  2. roryabraham
    self-assigned this
    on Mar 23, 2024
  3. roryabraham
    added this to Comment Linkingon Mar 23, 2024
  4. melvin-bot
    assigned
    shawnborton
    on Mar 23, 2024

  5. melvin-bot commented on Mar 23, 2024

    @melvin-bot
    melvin-botBot
    on Mar 23, 2024 – with Melvin Bot

    Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

  6. roryabraham
    moved this to Todo in Comment Linkingon Mar 23, 2024
  7. melvin-bot
    assigned
    kadiealexander
    on Mar 23, 2024

  8. melvin-bot commented on Mar 23, 2024

    @melvin-bot
    melvin-botBot
    on Mar 23, 2024 – with Melvin Bot

    Triggered auto assignment to @kadiealexander (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

  9. melvin-bot
    removed
    DailyKSv2
    on Mar 23, 2024

  10. roryabraham commented on Mar 23, 2024

    @roryabraham
    roryabraham
    on Mar 23, 2024
    ContributorAuthor

    hey @shawnborton, any thoughts on what color we could use to highlight the message that you linked to?

  11. quinthar
    added this to [#whatsnext] #vip-vsbon Mar 23, 2024
  12. quinthar
    moved this to HIGH in [#whatsnext] #vip-vsbon Mar 23, 2024

  13. 59 remaining items

  14. melvin-bot commented on Apr 8, 2024

    @melvin-bot
    melvin-botBot
    on Apr 8, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Apr 8, 2024

    @melvin-bot
    melvin-botBot
    on Apr 8, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-15. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on Apr 8, 2024

    @melvin-bot
    melvin-botBot
    on Apr 8, 2024 – with Melvin Bot

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  17. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Apr 14, 2024

  18. kadiealexander commented on Apr 15, 2024

    @kadiealexander
    kadiealexander
    on Apr 15, 2024
    Contributor

    Payouts due:

    Upwork job is here.

  19. kadiealexander commented on Apr 15, 2024

    @kadiealexander
    kadiealexander
    on Apr 15, 2024
    Contributor

    @Pujan92 please propose the regression test steps

  20. melvin-bot commented on Apr 19, 2024

    @melvin-bot
    melvin-botBot
    on Apr 19, 2024 – with Melvin Bot

    @shawnborton, @Pujan92, @roryabraham, @kadiealexander, @nkdengineer Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  21. melvin-bot
    added
    Overdue
    on Apr 19, 2024

  22. Pujan92 commented on Apr 19, 2024

    @Pujan92
    Pujan92
    on Apr 19, 2024
    Contributor

    Regression Test Proposal

    1. Copy link for any of the report message with the context menu
    2. Open that link
    3. Verify that the linked message is highlighted

    Do we agree 👍 or 👎

  23. melvin-bot
    added
    Overdue
    and removed
    Overdue
    on Apr 19, 2024
  24. kadiealexander
    closed this as completedon Apr 22, 2024
  25. melvin-bot
    removed
    Overdue
    on Apr 22, 2024
  26. github-project-automation
    moved this from In Progress to Done in Comment Linkingon Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2DesignExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions