[HOLD for payment 2024-04-05] [$250] [Simplified Collect][Distance rates] - Back icon not functioning and close to status bar on rate edit screen

@anmurali

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.56.0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #38237
Issue reported by: Applause - Internal team

Action Performed:

Precondition: user created a collect policy in OD

Open the app and log in as the admin of the collect policy
Navigate to the workspace settings > More features
Enable Distance rates
Open Distance rates
Select any distance rate
Tap the rate value
Tap the back icon

Expected Result:

The back icon is functioning, user can return to the previous screen

Actual Result:

The back icon is too close to the status bar and is not functioning

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6423960_1711160389870.video_2024-03-22_22-11-05.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~018bf3c7d04bca8505
Upwork Job ID: 1772188385248808960
Last Price Increase: 2024-03-25

Issue Owner

Current Issue Owner: @anmurali

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

We think that this bug might be related to #wave-collect - Release 1

@grgia

Triggered auto assignment to @grgia (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Back icon not functioning and close to status bar on rate edit screen

What is the root cause of that problem?

We do not pass shouldEnableMaxHeight:

App/src/pages/workspace/distanceRates/PolicyDistanceRateEditPage.tsx

Lines 66 to 71 in 2003844

    
           <ScreenWrapper 
        
               style={[styles.pb0]} 
        
               includePaddingTop={false} 
        
               includeSafeAreaPaddingBottom={false} 
        
               testID={PolicyDistanceRateEditPage.displayName} 
        
           >

What changes do you think we should make in order to solve the problem?

Pass shouldEnableMaxHeight & also update style to: style={[styles.defaultModalContainer]}

 <ScreenWrapper 
     style={[styles.defaultModalContainer]}
     includePaddingTop={false} 
     includeSafeAreaPaddingBottom={false} 
     testID={PolicyDistanceRateEditPage.displayName} 
     shouldEnableMaxHeight
 >

We already do that in edit tag and edit category page:

App/src/pages/workspace/tags/EditTagPage.tsx

Lines 74 to 79 in 2003844

    
           <ScreenWrapper 
        
               includeSafeAreaPaddingBottom={false} 
        
               style={[styles.defaultModalContainer]} 
        
               testID={EditTagPage.displayName} 
        
               shouldEnableMaxHeight 
        
           >

App/src/pages/workspace/categories/EditCategoryPage.tsx

Lines 49 to 54 in 2003844

    
           <ScreenWrapper 
        
               includeSafeAreaPaddingBottom={false} 
        
               style={[styles.defaultModalContainer]} 
        
               testID={EditCategoryPage.displayName} 
        
               shouldEnableMaxHeight 
        
           >

What alternative solutions did you explore? (Optional)

N/A

I am Michał from Callstack - expert contributor group. I’d like to work on this job.

Waiting on payment

Still pending payment

@anmurali

@anmurali, @luacmartins, @MrMuzyk, @mountiny, @eh2077 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@eh2077

Offer sent to @eh2077 - https://www.upwork.com/nx/wm/offer/101898363

@anmurali

@anmurali Accepted offer, thank you.

@anmurali

@anmurali, @luacmartins, @MrMuzyk, @mountiny, @eh2077 Huh... This is 4 days overdue. Who can take care of this?

@anmurali

@anmurali @eh2077 are we good to close this one?

@anmurali

@anmurali @eh2077 are we good to close this one?

Ah, still waiting for the payment.

Paid.

Navigation Menu

Repository navigation

[HOLD for payment 2024-04-05] [$250] [Simplified Collect][Distance rates] - Back icon not functioning and close to status bar on rate edit screen #38871

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

41 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<ScreenWrapper
	style={[styles.pb0]}
	includePaddingTop={false}
	includeSafeAreaPaddingBottom={false}
	testID={PolicyDistanceRateEditPage.displayName}
	>

	<ScreenWrapper
	includeSafeAreaPaddingBottom={false}
	style={[styles.defaultModalContainer]}
	testID={EditTagPage.displayName}
	shouldEnableMaxHeight
	>

[HOLD for payment 2024-04-05] [$250] [Simplified Collect][Distance rates] - Back icon not functioning and close to status bar on rate edit screen #38871

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

github-actions commented on Mar 23, 2024

kbecciv commented on Mar 23, 2024

melvin-bot commented on Mar 23, 2024

allgandalf commented on Mar 23, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

MrMuzyk commented on Mar 25, 2024

41 remaining items

luacmartins commented on Apr 14, 2024

luacmartins commented on Apr 15, 2024

melvin-bot commented on Apr 16, 2024

anmurali commented on Apr 17, 2024

eh2077 commented on Apr 17, 2024

melvin-bot commented on Apr 22, 2024

luacmartins commented on Apr 22, 2024

eh2077 commented on Apr 22, 2024

anmurali commented on Apr 23, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions